New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve JetBrains performance scenario for NuGet Update #3044

Closed
rrelyea opened this Issue Jun 24, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@rrelyea
Contributor

rrelyea commented Jun 24, 2016

Per email thread with JetBrains...let's ensure that they understand when to do less work.
In other cases (XAML Language Service), using batchstart and end worked.
Do we need new events to solve this?
If so, what should they be?
Should they only solve Update?
Or is install, restore, etc... too?
If all, should they use one generic event NuGetOperationStarting, NuGetOperationComplete, or events for each of those things.

@jainaashish

This comment has been minimized.

Show comment
Hide comment
@jainaashish

jainaashish Jun 28, 2016

Contributor

We looked through vs code as well as confirmed with them, there isn't seems to be a way to get VS batch start/ end state or events. So we will need to define our own events for batchStart and batchEnd which should work for a collective install/ uninstall packages irrespective of update, install, or restore operations.

Contributor

jainaashish commented Jun 28, 2016

We looked through vs code as well as confirmed with them, there isn't seems to be a way to get VS batch start/ end state or events. So we will need to define our own events for batchStart and batchEnd which should work for a collective install/ uninstall packages irrespective of update, install, or restore operations.

@jainaashish

This comment has been minimized.

Show comment
Hide comment
@jainaashish

jainaashish Jun 30, 2016

Contributor

Shared a private build of nuget batch events with Resharper team and awaiting their private build with implementation. Then we'll analyze it further.

Contributor

jainaashish commented Jun 30, 2016

Shared a private build of nuget batch events with Resharper team and awaiting their private build with implementation. Then we'll analyze it further.

@jainaashish

This comment has been minimized.

Show comment
Hide comment
@jainaashish

jainaashish Jul 19, 2016

Contributor

Merged d775d6fbdc1a25397fb8f1119b52b249a8940061
But still keeping it open to write spec for this.

Contributor

jainaashish commented Jul 19, 2016

Merged d775d6fbdc1a25397fb8f1119b52b249a8940061
But still keeping it open to write spec for this.

@jainaashish

This comment has been minimized.

Show comment
Hide comment
@jainaashish

jainaashish Jul 19, 2016

Contributor

Spec doc added at nuget home wiki and also updated in PR.

Contributor

jainaashish commented Jul 19, 2016

Spec doc added at nuget home wiki and also updated in PR.

jainaashish added a commit to NuGet/NuGet.Client that referenced this issue Jul 21, 2016

ComImport doesn't allow to embedded generics type so updated new batc…
…h event apis to use delegate instead.

Previous PR - #739

Original Issue - NuGet/Home#3044

jainaashish added a commit to NuGet/NuGet.Client that referenced this issue Jul 21, 2016

ComImport doesn't allow to embedded generics type so updated new batc…
…h event apis to use delegate instead.

Previous PR - #739

Original Issue - NuGet/Home#3044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment