New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuget pack for project.json ignores packOptions tags like summary, authors , owners etc #3161

Closed
rohit21agrawal opened this Issue Jul 18, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@rohit21agrawal
Contributor

rohit21agrawal commented Jul 18, 2016

packOptions in project.json supports the following tags:
(reference : https://docs.microsoft.com/en-us/dotnet/articles/core/tools/project-json#packoptions)
summary
tags
owners
releaseNotes
iconUrl
projectUrl
licenseUrl
requireLicenseAcceptance
repository
files

So far, we only support files and take the value of other tags from the root of project.json instead of the ones from packOptions.

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Jul 19, 2016

Contributor

Assuming we've never shipped a released version with support for metadata at the root of Project.json, let's ship support in nuget pack for packoptions only. If we do that syntax will work with dotnet pack and nuget pack. DotNet pack today supports the older metadata at the root. Let's move towards the packoptions only.

Contributor

rrelyea commented Jul 19, 2016

Assuming we've never shipped a released version with support for metadata at the root of Project.json, let's ship support in nuget pack for packoptions only. If we do that syntax will work with dotnet pack and nuget pack. DotNet pack today supports the older metadata at the root. Let's move towards the packoptions only.

@rohit21agrawal

This comment has been minimized.

Show comment
Hide comment
@rohit21agrawal

rohit21agrawal Jul 19, 2016

Contributor

@rrelyea
we currently do not have support for repository...should we add it?

Contributor

rohit21agrawal commented Jul 19, 2016

@rrelyea
we currently do not have support for repository...should we add it?

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Jul 19, 2016

Contributor

what does dotnet pack do with it? add it to the nuspec?

Contributor

rrelyea commented Jul 19, 2016

what does dotnet pack do with it? add it to the nuspec?

@rohit21agrawal

This comment has been minimized.

Show comment
Hide comment
@rohit21agrawal

rohit21agrawal Jul 20, 2016

Contributor

@rrelyea dotnet pack doesn't seem to add "repository" to nuspec, so I have left it out.

Contributor

rohit21agrawal commented Jul 20, 2016

@rrelyea dotnet pack doesn't seem to add "repository" to nuspec, so I have left it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment