New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SemVer 2.0.0 block from pack #3356

Closed
emgarten opened this Issue Aug 23, 2016 · 8 comments

Comments

Projects
None yet
5 participants
@emgarten
Contributor

emgarten commented Aug 23, 2016

Pack blocks SemVer 2.0.0 versions in packages. This should be removed.

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Aug 23, 2016

Enable SemVer 2.0.0 support for pack
Remove the pack check for SemVer 2.0.0 that block pack.
Include metadata when writing the version to the nuspec file. Metadata is not used anywhere in NuGet, but it should be persisted in the nuspec file for readers who choose to consume it.

Fixes NuGet/Home#3356
@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Aug 23, 2016

Contributor

Related to #1359

Contributor

emgarten commented Aug 23, 2016

Related to #1359

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Aug 23, 2016

Contributor

This change is needed for 3.5.0 RTM. Now that SemVer 2.0.0 is supported in the client it should be possible to create SemVer 2.0.0 packages.

Contributor

emgarten commented Aug 23, 2016

This change is needed for 3.5.0 RTM. Now that SemVer 2.0.0 is supported in the client it should be possible to create SemVer 2.0.0 packages.

@zhili1208 zhili1208 added this to the 3.5 RTM milestone Aug 26, 2016

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Aug 27, 2016

Enable SemVer 2.0.0 support for pack
Remove the pack check for SemVer 2.0.0 that block pack.
Include metadata when writing the version to the nuspec file. Metadata is not used anywhere in NuGet, but it should be persisted in the nuspec file for readers who choose to consume it.

Fixes NuGet/Home#3356

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Aug 27, 2016

Enable SemVer 2.0.0 support for pack
Remove the pack check for SemVer 2.0.0 that block pack.
Include metadata when writing the version to the nuspec file. Metadata is not used anywhere in NuGet, but it should be persisted in the nuspec file for readers who choose to consume it.

Fixes NuGet/Home#3356
@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Sep 1, 2016

Contributor

Note...spec was to warn when creating this package with a semver2.0 id.
When validating, please confirm the warning is being produced.

Contributor

rrelyea commented Sep 1, 2016

Note...spec was to warn when creating this package with a semver2.0 id.
When validating, please confirm the warning is being produced.

@kzu

This comment has been minimized.

Show comment
Hide comment
@kzu

kzu Sep 24, 2016

Is there a feed where we can get packages from CI for upcoming releases? (or even from dev branch?)

I desperately need a package containing this fix :)

kzu commented Sep 24, 2016

Is there a feed where we can get packages from CI for upcoming releases? (or even from dev branch?)

I desperately need a package containing this fix :)

@kzu

This comment has been minimized.

Show comment
Hide comment

kzu commented Sep 24, 2016

@Jaykul

This comment has been minimized.

Show comment
Hide comment
@Jaykul

Jaykul Sep 30, 2016

@kzu what build did you find worked? I tried the NuGet.Commandline package 3.6.0-rc-1927
and it still seems blocked?

Jaykul commented Sep 30, 2016

@kzu what build did you find worked? I tried the NuGet.Commandline package 3.6.0-rc-1927
and it still seems blocked?

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Sep 30, 2016

Contributor

@Jaykul what error did you get? It should be unblocked in 3.6.0-rc

You can find the latest 3.5.0 build which is close to RTM here: https://dotnet.myget.org/feed/nuget-build/package/nuget/NuGet.CommandLine/3.5.0-rtm-1829

Contributor

emgarten commented Sep 30, 2016

@Jaykul what error did you get? It should be unblocked in 3.6.0-rc

You can find the latest 3.5.0 build which is close to RTM here: https://dotnet.myget.org/feed/nuget-build/package/nuget/NuGet.CommandLine/3.5.0-rtm-1829

@Jaykul

This comment has been minimized.

Show comment
Hide comment
@Jaykul

Jaykul Oct 2, 2016

Thanks for your patience, when I looked through there, I missed the fact that the "3.5.0-rtm" files were hiding down under the betas 😊

Jaykul commented Oct 2, 2016

Thanks for your patience, when I looked through there, I missed the fact that the "3.5.0-rtm" files were hiding down under the betas 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment