Write out targets/props files on failed restore #3399

Closed
jainaashish opened this Issue Sep 1, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@jainaashish
Contributor

jainaashish commented Sep 1, 2016

Today we don't write *.nuget.targets and *.nuget.props files when a restore fails but could give some confusing errors to the users for .net core projects. So we should write these files irrespective of restore failed or succeed.

@rrelyea rrelyea added this to the 3.6 Beta1 milestone Sep 6, 2016

@rrelyea rrelyea modified the milestones: 3.6 Beta1, 3.6 Beta2, 3.6 RC Sep 22, 2016

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Dec 13, 2016

Contributor

@emgarten - did this already get fixed in 4.0?

Contributor

rrelyea commented Dec 13, 2016

@emgarten - did this already get fixed in 4.0?

@emgarten emgarten assigned emgarten and unassigned jainaashish Dec 14, 2016

@emgarten emgarten modified the milestones: 4.0 RC3, Future-1 Dec 14, 2016

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Dec 14, 2016

Contributor

@rrelyea I think so, if not I'll make sure we do along with the content files change with tests.

Contributor

emgarten commented Dec 14, 2016

@rrelyea I think so, if not I'll make sure we do along with the content files change with tests.

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Dec 16, 2016

Support for ContentFiles in generated props.
Fixes NuGet/Home#4098
Fixes NuGet/Home#3928
Fixes NuGet/Home#3683
Fixes NuGet/Home#4098
Fixes NuGet/Home#3399

Adding tests to verify files are written out on failure

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Dec 16, 2016

Support for ContentFiles in generated props.
Fixes NuGet/Home#4098
Fixes NuGet/Home#3928
Fixes NuGet/Home#3683
Fixes NuGet/Home#4098
Fixes NuGet/Home#3399

Adding tests to verify files are written out on failure

@emgarten emgarten referenced this issue in NuGet/NuGet.Client Dec 16, 2016

Closed

Support for ContentFiles in generated props. #1061

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Dec 16, 2016

Contributor

Related to #4116

Contributor

emgarten commented Dec 16, 2016

Related to #4116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment