New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuget picks unexpected version of MSBuild in VS "15" Preview 4 dev. command prompt #3408

Closed
paulvanbrenk opened this Issue Sep 5, 2016 · 5 comments

Comments

Projects
None yet
5 participants
@paulvanbrenk

paulvanbrenk commented Sep 5, 2016

Using the VS "15" developer command prompt Nuget.exe restore picks the MSBuild 4, which I didn't expect based on the output of the where command.

Nuget output:

C:\Projects\VSIXProject1>NuGet.exe restore VSIXProject1.sln
MSBuild auto-detection: using msbuild version '4.0' from 'C:\Windows\Microsoft.NET\Framework\v4.0.30319'.
C:\Projects\VSIXProject1>where msbuild
C:\Program Files (x86)\Microsoft Visual Studio 15.0\MSBuild\15.0\Bin\MSBuild.exe
C:\Windows\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe

This happens both for NuGet 3.4.4 and 3.5.0-rc1

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Sep 6, 2016

Collaborator

Which version do you get if you just run msbuild /version from your developer prompt?

NuGet tries to take the first one on the path, I'm not sure which would win here based on your where msbuild output.

https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Clients/NuGet.CommandLine/MsBuildUtility.cs#L262

Collaborator

emgarten commented Sep 6, 2016

Which version do you get if you just run msbuild /version from your developer prompt?

NuGet tries to take the first one on the path, I'm not sure which would win here based on your where msbuild output.

https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Clients/NuGet.CommandLine/MsBuildUtility.cs#L262

@paulvanbrenk

This comment has been minimized.

Show comment
Hide comment
@paulvanbrenk

paulvanbrenk Sep 6, 2016

Interesting:

C:\TypeScript\VS>msbuild /version
Microsoft (R) Build Engine version 15.1.188.30335
Copyright (C) Microsoft Corporation. All rights reserved.

15.1.188.30335

paulvanbrenk commented Sep 6, 2016

Interesting:

C:\TypeScript\VS>msbuild /version
Microsoft (R) Build Engine version 15.1.188.30335
Copyright (C) Microsoft Corporation. All rights reserved.

15.1.188.30335
@drewgillies

This comment has been minimized.

Show comment
Hide comment
@drewgillies

drewgillies Sep 7, 2016

Contributor

The path isn't the only issue here. nuget.exe uses the path to find an MSBuild version prior to 15.1. But MSBuild 15.1 is a whole new ballgame, and nuget.exe needs to adapt. I have a prototype which should see the light of day soon.

Contributor

drewgillies commented Sep 7, 2016

The path isn't the only issue here. nuget.exe uses the path to find an MSBuild version prior to 15.1. But MSBuild 15.1 is a whole new ballgame, and nuget.exe needs to adapt. I have a prototype which should see the light of day soon.

@paulvanbrenk

This comment has been minimized.

Show comment
Hide comment
@paulvanbrenk

paulvanbrenk Sep 7, 2016

@drewgil Thanks for looking into this, if you need anything from me let me know.

paulvanbrenk commented Sep 7, 2016

@drewgil Thanks for looking into this, if you need anything from me let me know.

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Jan 10, 2017

Contributor

Fixed in RC3

Contributor

rrelyea commented Jan 10, 2017

Fixed in RC3

@rrelyea rrelyea closed this Jan 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment