Solution Restore and Build Restore still show dialogs #3789

Closed
rrelyea opened this Issue Oct 27, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@rrelyea
Contributor

rrelyea commented Oct 27, 2016

when in .net core projects, there should be no way to see a restoring dialog.

1file new project> asp.net core web app
2auto restore works.
3 if you build, restore dialog shows up
or
4 if you solution restore, restore dialog shows up

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Oct 27, 2016

Contributor

evaluate risk, for .net core only. then for that and uwp.

Contributor

rrelyea commented Oct 27, 2016

evaluate risk, for .net core only. then for that and uwp.

@rrelyea rrelyea modified the milestones: 4.0 RC2, 4.0 RC Oct 27, 2016

@rrelyea rrelyea modified the milestones: 4.0 RC3, 4.0 RC2 Nov 28, 2016

alpaix added a commit to alpaix/NuGet.Client that referenced this issue Dec 10, 2016

Auto-Restore UI normalization
Resolves NuGet/Home#3633, NuGet/Home#3789, NuGet/Home#3835,
NuGet/Home#3884.

The purpose of this change is to make consistent UX in all restore
scenarios: auto-restore, on-build restore, and solution restore. At the
same time each scenario has some nuances, whereas:
- Auto-restore and solution restore should write log messages in PM console
output window.
- On-build restore writes inline log messages in build output window.

Introduced new console type: `BuildOutputConsole`. It allows writing into
the VS build output window via `IOutputConsole` abstraction API.

Moved `SolutionRestoreCommand` into the solutuion restore package. As the
latter loads on solution open so the restore command should be available
at this point. At the same time the command invokation shouldn't trigger
loading of the legacy package.

Also had to do some refactoring in order to consume `VsConsole` API in
Solution Restore implementation classes:
- Moved all `SolutionRestore*` artifacts into
  `NuGet.SolutionRestoreManager` project.

Eliminated dead code including remnants of debug console and standalone
console.

@alpaix alpaix referenced this issue in NuGet/NuGet.Client Dec 10, 2016

Merged

Auto-Restore UI normalization #1052

alpaix added a commit to alpaix/NuGet.Client that referenced this issue Dec 12, 2016

Auto-Restore UI normalization
Resolves NuGet/Home#3633, NuGet/Home#3789, NuGet/Home#3835,
NuGet/Home#3884.

The purpose of this change is to make consistent UX in all restore
scenarios: auto-restore, on-build restore, and solution restore. At the
same time each scenario has some nuances, whereas:
- Auto-restore and solution restore should write log messages in PM console
output window.
- On-build restore writes inline log messages in build output window.

Introduced new console type: `BuildOutputConsole`. It allows writing into
the VS build output window via `IOutputConsole` abstraction API.

Moved `SolutionRestoreCommand` into the solutuion restore package. As the
latter loads on solution open so the restore command should be available
at this point. At the same time the command invokation shouldn't trigger
loading of the legacy package.

Also had to do some refactoring in order to consume `VsConsole` API in
Solution Restore implementation classes:
- Moved all `SolutionRestore*` artifacts into
  `NuGet.SolutionRestoreManager` project.

Eliminated dead code including remnants of debug console and standalone
console.

alpaix added a commit to alpaix/NuGet.Client that referenced this issue Dec 13, 2016

Auto-Restore UI normalization
Resolves NuGet/Home#3633, NuGet/Home#3789, NuGet/Home#3835,
NuGet/Home#3884.

The purpose of this change is to make consistent UX in all restore
scenarios: auto-restore, on-build restore, and solution restore. At the
same time each scenario has some nuances, whereas:
- Auto-restore and solution restore should write log messages in PM console
output window.
- On-build restore writes inline log messages in build output window.

Introduced new console type: `BuildOutputConsole`. It allows writing into
the VS build output window via `IOutputConsole` abstraction API.

Moved `SolutionRestoreCommand` into the solutuion restore package. As the
latter loads on solution open so the restore command should be available
at this point. At the same time the command invokation shouldn't trigger
loading of the legacy package.

Also had to do some refactoring in order to consume `VsConsole` API in
Solution Restore implementation classes:
- Moved all `SolutionRestore*` artifacts into
  `NuGet.SolutionRestoreManager` project.

Eliminated dead code including remnants of debug console and standalone
console.

alpaix added a commit to NuGet/NuGet.Client that referenced this issue Dec 13, 2016

Auto-Restore UI normalization
Resolves NuGet/Home#3633, NuGet/Home#3789, NuGet/Home#3835,
NuGet/Home#3884.

The purpose of this change is to make consistent UX in all restore
scenarios: auto-restore, on-build restore, and solution restore. At the
same time each scenario has some nuances, whereas:
- Auto-restore and solution restore should write log messages in PM console
output window.
- On-build restore writes inline log messages in build output window.

Introduced new console type: `BuildOutputConsole`. It allows writing into
the VS build output window via `IOutputConsole` abstraction API.

Moved `SolutionRestoreCommand` into the solutuion restore package. As the
latter loads on solution open so the restore command should be available
at this point. At the same time the command invokation shouldn't trigger
loading of the legacy package.

Also had to do some refactoring in order to consume `VsConsole` API in
Solution Restore implementation classes:
- Moved all `SolutionRestore*` artifacts into
  `NuGet.SolutionRestoreManager` project.

Eliminated dead code including remnants of debug console and standalone
console.

alpaix added a commit to alpaix/NuGet.Client that referenced this issue Dec 14, 2016

Auto-Restore UI normalization
Resolves NuGet/Home#3633, NuGet/Home#3789, NuGet/Home#3835,
NuGet/Home#3884.

The purpose of this change is to make consistent UX in all restore
scenarios: auto-restore, on-build restore, and solution restore. At the
same time each scenario has some nuances, whereas:
- Auto-restore and solution restore should write log messages in PM console
output window.
- On-build restore writes inline log messages in build output window.

Introduced new console type: `BuildOutputConsole`. It allows writing into
the VS build output window via `IOutputConsole` abstraction API.

Moved `SolutionRestoreCommand` into the solutuion restore package. As the
latter loads on solution open so the restore command should be available
at this point. At the same time the command invokation shouldn't trigger
loading of the legacy package.

Also had to do some refactoring in order to consume `VsConsole` API in
Solution Restore implementation classes:
- Moved all `SolutionRestore*` artifacts into
  `NuGet.SolutionRestoreManager` project.

Eliminated dead code including remnants of debug console and standalone
console.
@alpaix

This comment has been minimized.

Show comment
Hide comment

alpaix commented Dec 14, 2016

Resolved with NuGet/NuGet.Client#1052.

@alpaix alpaix closed this Dec 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment