Trim whitespace from MSBuild properties #3819

Closed
emgarten opened this Issue Oct 29, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@emgarten
Contributor

emgarten commented Oct 29, 2016

NuGet should trim whitespace from MSBuild properties

dotnet/cli#4523

@prafullbhosale

This comment has been minimized.

Show comment
Hide comment
@prafullbhosale

prafullbhosale Oct 31, 2016

@emgarten will this fix be available for the Dev15 RC time frame?

@balachir, @barrytang

@emgarten will this fix be available for the Dev15 RC time frame?

@balachir, @barrytang

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Nov 1, 2016

Contributor

@prafullbhosale no this fix is marked for RC2.

Contributor

emgarten commented Nov 1, 2016

@prafullbhosale no this fix is marked for RC2.

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Nov 8, 2016

Trim whitespace from MSBuild properties
MSBuildRestoreUtility.Split now performs additional trimming on items in the set.
IMSBuildItem.GetProperty now trims values by default, an optional bool may be passed to get the original value if needed.

Fixes NuGet/Home#3819

@emgarten emgarten referenced this issue in NuGet/NuGet.Client Nov 8, 2016

Closed

Trim whitespace from MSBuild properties #1011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment