dotnet pack always seems to set ProjectReference version to 1.0.0 #3874

Closed
joelverhagen opened this Issue Nov 3, 2016 · 8 comments

Comments

Projects
None yet
3 participants
@joelverhagen
Member

joelverhagen commented Nov 3, 2016

Steps

  1. dotnet new to .csproj (projectA and projectB)
  2. Set <Version>2.0.0</Version> in projectB
  3. Add a <ProjectReference> between the (projectA -> projectB)
  4. Restore both.
  5. Build both.
  6. dotnet pack projectA
  7. Look at the output .nuspec.

Expected

The version of the projectB dependency should be 2.0.0.

Actual

The version of the projectB dependency seems to be a default 1.0.0.

dotnet --info

.NET Command Line Tools (1.0.0-preview3-004007)

Product Information:
 Version:            1.0.0-preview3-004007
 Commit SHA-1 hash:  80ec02b4da

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.14393
 OS Platform: Windows
 RID:         win10-x64

@joelverhagen joelverhagen added this to the 4.0 RC milestone Nov 3, 2016

@joelverhagen

This comment has been minimized.

Show comment
Hide comment
@joelverhagen

joelverhagen Nov 3, 2016

Member

/cc @rrelyea not sure if this is RC or RC2.

Member

joelverhagen commented Nov 3, 2016

/cc @rrelyea not sure if this is RC or RC2.

@rrelyea rrelyea modified the milestones: 4.0 RC2, 4.0 RC Nov 4, 2016

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Nov 4, 2016

Contributor

RC2 and release note.

Contributor

rrelyea commented Nov 4, 2016

RC2 and release note.

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Nov 4, 2016

Contributor

This is likely related to: #3748

Contributor

emgarten commented Nov 4, 2016

This is likely related to: #3748

@rrelyea rrelyea modified the milestones: 4.0 RC, 4.0 RC2 Nov 4, 2016

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Nov 4, 2016

Contributor

Please confirm if nuget pack has the same problem, and if there is a workaround.

Contributor

rrelyea commented Nov 4, 2016

Please confirm if nuget pack has the same problem, and if there is a workaround.

@joelverhagen

This comment has been minimized.

Show comment
Hide comment
@joelverhagen

joelverhagen Nov 4, 2016

Member

Workaround

Put this in the reference projects:

<PackageVersion Condition="'$(PackageVersion)' == ''">$(Version)</PackageVersion>
Member

joelverhagen commented Nov 4, 2016

Workaround

Put this in the reference projects:

<PackageVersion Condition="'$(PackageVersion)' == ''">$(Version)</PackageVersion>
@joelverhagen

This comment has been minimized.

Show comment
Hide comment
@joelverhagen

joelverhagen Nov 7, 2016

Member

This has only been checked into dev (4.0.0-rc2). This should be closed when we cherry-pick to 4.0.0-rc branch.

Member

joelverhagen commented Nov 7, 2016

This has only been checked into dev (4.0.0-rc2). This should be closed when we cherry-pick to 4.0.0-rc branch.

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Dec 6, 2016

Contributor

@joelverhagen can this be closed?

Contributor

emgarten commented Dec 6, 2016

@joelverhagen can this be closed?

@joelverhagen

This comment has been minimized.

Show comment
Hide comment
@joelverhagen

joelverhagen Dec 7, 2016

Member

@rrelyea, I guess it's safe to say we're not shipping this in RC right? 😄

Member

joelverhagen commented Dec 7, 2016

@rrelyea, I guess it's safe to say we're not shipping this in RC right? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment