dotnet pack is packing from obj not bin #3880

Closed
rrelyea opened this Issue Nov 4, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@rrelyea
Contributor

rrelyea commented Nov 4, 2016

Found by cli team.

@rrelyea rrelyea added this to the 4.0 RC2 milestone Nov 4, 2016

joelverhagen added a commit to joelverhagen/NuGet.Client that referenced this issue Nov 4, 2016

Use the FinalOutputPath instead of the Identity of output items
The targets BuiltProjectOutputGroup and DocumentationProjectOutputGroup produce the output items
Fix NuGet/Home#3880

@rrelyea rrelyea modified the milestones: 4.0 RC, 4.0 RC2 Nov 5, 2016

joelverhagen added a commit to joelverhagen/NuGet.Client that referenced this issue Nov 7, 2016

Use the FinalOutputPath instead of the Identity of output items
The targets BuiltProjectOutputGroup and DocumentationProjectOutputGroup produce the output items
Fix NuGet/Home#3880
@joelverhagen

This comment has been minimized.

Show comment
Hide comment
@joelverhagen

joelverhagen Nov 7, 2016

Member

This has only been checked into dev (4.0.0-rc2). This should be closed when we cherry-pick to 4.0.0-rc branch.

Member

joelverhagen commented Nov 7, 2016

This has only been checked into dev (4.0.0-rc2). This should be closed when we cherry-pick to 4.0.0-rc branch.

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Nov 8, 2016

Contributor

?

Contributor

rrelyea commented Nov 8, 2016

?

@joelverhagen

This comment has been minimized.

Show comment
Hide comment
@joelverhagen

joelverhagen Nov 8, 2016

Member

Weird. Pushing to a fork should not cause this...

Member

joelverhagen commented Nov 8, 2016

Weird. Pushing to a fork should not cause this...

@joelverhagen joelverhagen reopened this Nov 8, 2016

@joelverhagen

This comment has been minimized.

Show comment
Hide comment
@joelverhagen

joelverhagen Nov 8, 2016

Member

Hmmm come to think of it how would GitHub know the affinity between NuGet/Home and NuGet/NuGet.Client repositories? How would it know there is any different relationship with drewgil/NuGet.Client. I think this is not a bug.

Member

joelverhagen commented Nov 8, 2016

Hmmm come to think of it how would GitHub know the affinity between NuGet/Home and NuGet/NuGet.Client repositories? How would it know there is any different relationship with drewgil/NuGet.Client. I think this is not a bug.

@drewgillies

This comment has been minimized.

Show comment
Hide comment
@drewgillies

drewgillies Nov 8, 2016

Contributor

Something is amiss. According to this I pushed a commit to my fork of another repo, a commit of code that I didn't write, and it somehow associated a close event with a bug to which I'm not assigned.

Contributor

drewgillies commented Nov 8, 2016

Something is amiss. According to this I pushed a commit to my fork of another repo, a commit of code that I didn't write, and it somehow associated a close event with a bug to which I'm not assigned.

dtivel added a commit to dtivel/NuGet.Client that referenced this issue Nov 9, 2016

Use the FinalOutputPath instead of the Identity of output items (#999)
The targets BuiltProjectOutputGroup and DocumentationProjectOutputGroup produce the output items
Fix NuGet/Home#3880

@joelverhagen joelverhagen modified the milestones: 4.0 RC2, 4.0 RC Dec 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment