Correctly communicate PackageSpec.Version for any project dependencies (PackageRef) #3902

Closed
emgarten opened this Issue Nov 8, 2016 · 1 comment

Comments

Projects
None yet
4 participants
@emgarten
Contributor

emgarten commented Nov 8, 2016

The legacy CSProj project system should set the PackageSpec version for a project based on:

  1. PackageVersion if it exists
  2. Version if it exists
  3. 1.0.0 otherwise

This matches the pack and NuGet.targets behavior for determining a package version.

The version string must be valid, otherwise this should fail with a helpful error.

Original issue:
#3748

@emgarten emgarten added this to the 4.0 RC2 milestone Nov 8, 2016

@drewgillies drewgillies self-assigned this Nov 23, 2016

@rrelyea rrelyea modified the milestones: 4.0 RC2, 4.0 RC3 Nov 29, 2016

@drewgillies drewgillies removed their assignment Dec 20, 2016

@rrelyea rrelyea changed the title from Set PackageSpec.Version for Legacy CSProj projects to Correctly communicate PackageSpec.Version for any project dependencies (PackageRef) Jan 9, 2017

@rrelyea rrelyea added the 4.0Triage label Jan 9, 2017

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Jan 11, 2017

Contributor

Has been approved for a checkin to dev (but NOT release-4.0.0-rc3). Please merge when ready.

Contributor

rrelyea commented Jan 11, 2017

Has been approved for a checkin to dev (but NOT release-4.0.0-rc3). Please merge when ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment