Improve unresolved reference warning #3955

Closed
emgarten opened this Issue Nov 15, 2016 · 0 comments

Comments

Projects
None yet
3 participants
@emgarten
Contributor

emgarten commented Nov 15, 2016

When resolving project references through DTE NuGet writes out a warning when the reference is unresolved since it may be a project reference and this could impact the restore result.

In 3.5.0 these were written out while walking the root project and traversing through child projects.

In 4.0.0 these are written out while generating the package spec for a project individually. This is more efficient but the result is that warnings now show up in scenarios where they are not part of a p2p closure. They also do not list the root project that is affected since that is not know until later.

This should be improved by setting a bool in the package spec restore metadata declaring that the project had issues resolving references. The reader putting together the p2p closure can then provide a complete warning message, or it can skip the warning if the project is not part of a closure.

capture

@rrelyea rrelyea added this to the 3.5 RTM milestone Dec 9, 2016

@rrelyea rrelyea added the Type:Bug label Dec 9, 2016

@rrelyea rrelyea modified the milestones: 4.0 RTM, 3.5 RTM Dec 9, 2016

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Dec 28, 2016

Improve failed project reference item
This message can occur when any item in a project fails to resolve and Visual Studio DTE is unable to return it. This is a problem if the item is a project reference, but the rest of the time it does not impact NuGet. Based on the current feedback this message is appearing much more frequently and leading users to believe that there was a restore error when there was not.

The intent of the actual message is just to inform users that if they do see missing packages that it could have been caused by a broken project reference.

The fix for this is to move the message from warning to verbose. If a user does hit the rare scenario of getting an incomplete restore they can debug it by increasing their verbosity and reading the new, more helpful, message.

Fixes NuGet/Home#3955

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Dec 28, 2016

Improve failed project reference item
This message can occur when any item in a project fails to resolve and Visual Studio DTE is unable to return it. This is a problem if the item is a project reference, but the rest of the time it does not impact NuGet. Based on the current feedback this message is appearing much more frequently and leading users to believe that there was a restore error when there was not.

The intent of the actual message is just to inform users that if they do see missing packages that it could have been caused by a broken project reference.

The fix for this is to move the message from warning to verbose. If a user does hit the rare scenario of getting an incomplete restore they can debug it by increasing their verbosity and reading the new, more helpful, message.

Fixes NuGet/Home#3955

@emgarten emgarten referenced this issue in NuGet/NuGet.Client Dec 28, 2016

Merged

Improve failed project reference item #1077

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Dec 28, 2016

Improve failed project reference item
This message can occur when any item in a project fails to resolve and Visual Studio DTE is unable to return it. This is a problem if the item is a project reference, but the rest of the time it does not impact NuGet. Based on the current feedback this message is appearing much more frequently and leading users to believe that there was a restore error when there was not.

The intent of the actual message is just to inform users that if they do see missing packages that it could have been caused by a broken project reference.

The fix for this is to move the message from warning to verbose. If a user does hit the rare scenario of getting an incomplete restore they can debug it by increasing their verbosity and reading the new, more helpful, message.

Fixes NuGet/Home#3955

mishra14 added a commit to NuGet/NuGet.Client that referenced this issue Jan 5, 2017

Improve failed project reference item
This message can occur when any item in a project fails to resolve and Visual Studio DTE is unable to return it. This is a problem if the item is a project reference, but the rest of the time it does not impact NuGet. Based on the current feedback this message is appearing much more frequently and leading users to believe that there was a restore error when there was not.

The intent of the actual message is just to inform users that if they do see missing packages that it could have been caused by a broken project reference.

The fix for this is to move the message from warning to verbose. If a user does hit the rare scenario of getting an incomplete restore they can debug it by increasing their verbosity and reading the new, more helpful, message.

Fixes NuGet/Home#3955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment