Install doesn't work for PackageRefernces with dependencies (package spec problem) #4015

Closed
drewgillies opened this Issue Nov 28, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@drewgillies
Contributor

drewgillies commented Nov 28, 2016

Repro Steps:

  1. New a C# Console App (.Net Framwork).
  2. Add the following properties to the property group at the top of the csproj file:
    <RuntimeIdentifiers Condition="'$(RuntimeIdentifiers)'==''">win</RuntimeIdentifiers>
  3. Add the following reference to the csproj file, before the final targets import line starting with
<Import Project="$(MSBuild...
<ItemGroup> 
        <PackageReference Include="Newtonsoft.Json"> 
<Version>9.0.1</Version> 
        </PackageReference> 
</ItemGroup>

From Rob: (by the way, version as attribute on the packagereference is the preferred form...please ensure that the csproj project system defaults to that serialization form when adding packages. ideally, it also preserves whichever form the user had in the csproj)

  1. Reload the project in VS and run solution restore.
  2. Open PM UI and install package ‘NUnit’ 3.5.0
  3. Observe the ‘Installed’ tab.

Expected:
Installed packages show in installed tab.

Actual:
Nothing show in installed tab.

@drewgillies

This comment has been minimized.

Show comment
Hide comment
@drewgillies

drewgillies Nov 28, 2016

Contributor

Raised by Andy T in legacy csproj scenario testing. I'm not convinced this is a regression as I've seen the blank Install tab in UWP/console on occasion before (but haven't deduced repro steps). But this is a solid repro.

Contributor

drewgillies commented Nov 28, 2016

Raised by Andy T in legacy csproj scenario testing. I'm not convinced this is a regression as I've seen the blank Install tab in UWP/console on occasion before (but haven't deduced repro steps). But this is a solid repro.

@jainaashish jainaashish self-assigned this Nov 29, 2016

@jainaashish jainaashish added this to the 4.0 RC2 milestone Nov 29, 2016

@jainaashish jainaashish modified the milestones: 4.0 RC3, 4.0 RC2 Nov 29, 2016

@jainaashish jainaashish referenced this issue in NuGet/NuGet.Client Nov 29, 2016

Merged

Fix package spec for legacy csproj #1039

@jainaashish jainaashish modified the milestones: 4.0 RC2, 4.0 RC3 Nov 29, 2016

@jainaashish

This comment has been minimized.

Show comment
Hide comment
@jainaashish

jainaashish Nov 29, 2016

Contributor

Merged to Dev #17fe755c4d8bc3f50fe1de53b26bae0976db10a7 Waiting for RC2 decision

Contributor

jainaashish commented Nov 29, 2016

Merged to Dev #17fe755c4d8bc3f50fe1de53b26bae0976db10a7 Waiting for RC2 decision

@jainaashish jainaashish reopened this Nov 29, 2016

@rrelyea rrelyea modified the milestones: 4.0 RC3, 4.0 RC2 Nov 30, 2016

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Nov 30, 2016

Contributor

Let's do this in RC3. So go ahead and close.

Contributor

rrelyea commented Nov 30, 2016

Let's do this in RC3. So go ahead and close.

@jainaashish jainaashish closed this Dec 5, 2016

@rrelyea rrelyea changed the title from Can not find installed packages in package manager UI to Install doesn't work for PackageRefernces with dependencies (package spec problem) Aug 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment