New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New background restore writes milliseconds to status bar when it takes seconds to restore #4036

Closed
davkean opened this Issue Nov 30, 2016 · 1 comment

Comments

Projects
None yet
4 participants
@davkean

davkean commented Nov 30, 2016

Can we use a more appropriate duration - measuring something in ms when it takes seconds just looks silly:

image

@yishaigalatzer

This comment has been minimized.

Show comment
Hide comment
@yishaigalatzer

yishaigalatzer Nov 30, 2016

The code should use the same pattern we use everywhere else - milliseconds if smaller than a second, seconds:milliseconds up to 60 seconds, minutes:seconds, (hours:minutes ???)

@alpaix @rrelyea

yishaigalatzer commented Nov 30, 2016

The code should use the same pattern we use everywhere else - milliseconds if smaller than a second, seconds:milliseconds up to 60 seconds, minutes:seconds, (hours:minutes ???)

@alpaix @rrelyea

@rrelyea rrelyea added this to the 4.0 RC3 milestone Dec 5, 2016

alpaix added a commit to alpaix/NuGet.Client that referenced this issue Dec 13, 2016

Write restore summary in readable time format
Resolves NuGet/Home#4036.

Using `DatetimeUtility.ToReadableTimeFormat` to log elapsed time of
restore operation.

alpaix added a commit to alpaix/NuGet.Client that referenced this issue Dec 13, 2016

Write restore summary in readable time format
Resolves NuGet/Home#4036.

Using `DatetimeUtility.ToReadableTimeFormat` to log elapsed time of
restore operation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment