Define a new ProjectCapability "Pack" in Pack targets for enabling Package related capabilities #4146

Closed
mavasani opened this Issue Dec 22, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@mavasani

Recently, we added a new Package property page and a context menu command to execute Pack for dotnet core projects in roslyn-project-system. Both the property page and the command are conditioned on a ProjectCapability named "Pack". @srivatsn recommended that this project capability should be defined in the Pack targets, so that only the SDK/project importing this target get these new features.

@mavasani

This comment has been minimized.

Show comment
Hide comment

mavasani added a commit to mavasani/project-system that referenced this issue Dec 22, 2016

@rrelyea rrelyea added this to the 4.0 RC3 milestone Dec 27, 2016

@rohit21agrawal

This comment has been minimized.

Show comment
Hide comment
@rohit21agrawal

rohit21agrawal Dec 30, 2016

Contributor

@srivatsn @mavasani can you guys point me to how a ProjectCapability is added in a target file?

Contributor

rohit21agrawal commented Dec 30, 2016

@srivatsn @mavasani can you guys point me to how a ProjectCapability is added in a target file?

@mavasani

This comment has been minimized.

Show comment
Hide comment
@mavasani

mavasani Dec 30, 2016

You just need to add an item group with the capability like following:

<ItemGroup Condition="???">
     <ProjectCapability Include="Pack"/>
</ItempGroup>

You just need to add an item group with the capability like following:

<ItemGroup Condition="???">
     <ProjectCapability Include="Pack"/>
</ItempGroup>
@srivatsn

This comment has been minimized.

Show comment
Hide comment
@srivatsn

srivatsn Jan 3, 2017

@rohit21agrawal - how will the SDK pick up this package? I assume a vs insertion is needed for this to show up?

srivatsn commented Jan 3, 2017

@rohit21agrawal - how will the SDK pick up this package? I assume a vs insertion is needed for this to show up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment