NuGet 3.5.0 not unpacking *.targets from package #4171

Closed
mausch opened this Issue Dec 30, 2016 · 7 comments

Comments

Projects
None yet
5 participants
@mausch

mausch commented Dec 30, 2016

Details about Problem

NuGet 3.5.0
Windows 10
Worked before in NuGet 3.3

Detailed repro steps so we can see the same problem

  1. Create a new project, add https://www.nuget.org/packages/Microsoft.Net.Compilers/1.3.2 with NuGet 3.3
  2. Delete all files in the packages directory.
  3. Restore packages with NuGet 3.5
  4. Project build now fails with error:
C:\Program Files (x86)\MSBuild\14.0\bin\Microsoft.CSharp.CurrentVersion.targets(321,5): error MSB4019: 
The imported project "C:\myproject\packages\Microsoft.Net.Compilers.1.3.2\tools\Microsoft.CSharp.Core.targets" was not found. 
Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.

NuGet 3.5 does not unpack any tools\*.targets files when restoring this package, but NuGet 3.3 does.

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Dec 30, 2016

Contributor

@mausch - can you please test to see if NuGet 3.4.4 works?
Are you using nuget.exe and msbuild -- or doing this all inside of VS?
Which version of VS?

Contributor

rrelyea commented Dec 30, 2016

@mausch - can you please test to see if NuGet 3.4.4 works?
Are you using nuget.exe and msbuild -- or doing this all inside of VS?
Which version of VS?

@rrelyea rrelyea added the Viewed label Dec 30, 2016

@mausch

This comment has been minimized.

Show comment
Hide comment
@mausch

mausch Jan 3, 2017

3.4.4 does unpack *.targets files.
This is all just using nuget.exe

mausch commented Jan 3, 2017

3.4.4 does unpack *.targets files.
This is all just using nuget.exe

@rrelyea rrelyea added this to the 4.0 RC3 milestone Jan 3, 2017

@rrelyea rrelyea added Area: Pack Type:Bug and removed Viewed labels Jan 3, 2017

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Jan 3, 2017

Contributor

@rohit21agrawal - Sounds to be a pack regression from 3.4.4 that shipped in 3.5.0.
Can you please investigate?
Still happening in 4.0 release candidates?

Contributor

rrelyea commented Jan 3, 2017

@rohit21agrawal - Sounds to be a pack regression from 3.4.4 that shipped in 3.5.0.
Can you please investigate?
Still happening in 4.0 release candidates?

@rohit21agrawal

This comment has been minimized.

Show comment
Hide comment
@rohit21agrawal

rohit21agrawal Jan 3, 2017

Contributor

AFAIK , targets files need to be in build or buildCrossTargeting folder to be restored. In any case, this is likely a restore issue. @emgarten - comments?

Contributor

rohit21agrawal commented Jan 3, 2017

AFAIK , targets files need to be in build or buildCrossTargeting folder to be restored. In any case, this is likely a restore issue. @emgarten - comments?

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Jan 3, 2017

Contributor

@mausch can you share some repro steps? I'm not seeing this problem.

Here is what I tried:

  1. Create a new console app in VS 2015
  2. Install-Package Microsoft.Net.Compilers -Version 1.3.2
  3. Verified packages\Microsoft.Net.Compilers.1.3.2\tools\Microsoft.CSharp.Core.targets was present
  4. Deleted packages folder
  5. nuget.exe restore Solution.sln
  6. Verified packages\Microsoft.Net.Compilers.1.3.2\tools\Microsoft.CSharp.Core.targets was present

I tried this with NuGet.exe 3.5.0 RTM and NuGet.exe 3.5.0 beta2 and did not see any cases where the targets were not extracted.

Contributor

emgarten commented Jan 3, 2017

@mausch can you share some repro steps? I'm not seeing this problem.

Here is what I tried:

  1. Create a new console app in VS 2015
  2. Install-Package Microsoft.Net.Compilers -Version 1.3.2
  3. Verified packages\Microsoft.Net.Compilers.1.3.2\tools\Microsoft.CSharp.Core.targets was present
  4. Deleted packages folder
  5. nuget.exe restore Solution.sln
  6. Verified packages\Microsoft.Net.Compilers.1.3.2\tools\Microsoft.CSharp.Core.targets was present

I tried this with NuGet.exe 3.5.0 RTM and NuGet.exe 3.5.0 beta2 and did not see any cases where the targets were not extracted.

@rrelyea rrelyea modified the milestones: 4.0 RTM, 4.0 RC3 Jan 4, 2017

@rrelyea rrelyea added Area: Restore and removed Area: Pack labels Jan 5, 2017

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Jan 12, 2017

Contributor

@mausch - can you please answer @emgarten's request from above for more details.

Contributor

rrelyea commented Jan 12, 2017

@mausch - can you please answer @emgarten's request from above for more details.

@mausch

This comment has been minimized.

Show comment
Hide comment
@mausch

mausch Jan 16, 2017

Weird, I can't reproduce it any more. I'll close this now, sorry for the trouble.

mausch commented Jan 16, 2017

Weird, I can't reproduce it any more. I'll close this now, sorry for the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment