New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add package command should add version as attribute instead of element #4325

Closed
mishra14 opened this Issue Jan 19, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@mishra14
Collaborator

mishra14 commented Jan 19, 2017

Created from : dotnet/cli#5386

Current :

  <ItemGroup>
    <PackageReference Include="System.ValueTuple">
      <Version>4.3.0</Version>
    </PackageReference>
  </ItemGroup>

Expected:

  <ItemGroup>
    <PackageReference Include="System.ValueTuple" Version="4.3.0" />
  </ItemGroup>

@rrelyea

@DustinCampbell

This comment has been minimized.

Show comment
Hide comment
@DustinCampbell

DustinCampbell Jan 21, 2017

Adding myself over here so I can track.

DustinCampbell commented Jan 21, 2017

Adding myself over here so I can track.

@rrelyea rrelyea modified the milestones: 4.0.1, 4.0 RTM Jan 24, 2017

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Jan 24, 2017

Contributor

Per email, failed barcheck for RTM in vs client Shiproom. moving to post rtm.

Contributor

rrelyea commented Jan 24, 2017

Per email, failed barcheck for RTM in vs client Shiproom. moving to post rtm.

@rrelyea rrelyea changed the title from add package command should add version as attribute to add package command should add version as attribute instead of element Feb 8, 2017

@nkolev92

This comment has been minimized.

Show comment
Hide comment
@nkolev92

nkolev92 Feb 8, 2017

Member

@mishra14
#4440
Is the above issue a dup of this one?

Member

nkolev92 commented Feb 8, 2017

@mishra14
#4440
Is the above issue a dup of this one?

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Feb 9, 2017

Contributor

Please finish PR review/feedback (if any).
Then ensure you've tested it all it needs.
Then merge into dev.

Contributor

rrelyea commented Feb 9, 2017

Please finish PR review/feedback (if any).
Then ensure you've tested it all it needs.
Then merge into dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment