vsfeedback - Pack warnings when targeting netcoreapp1.1 #4397

Closed
rrelyea opened this Issue Jan 25, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@rrelyea
Contributor

rrelyea commented Jan 25, 2017

vsfeedback 746030

  1. Create netstandard class library
  2. Change TargetFrameworks to "netstandard1.4;net451;netcoreapp1.1"
  3. Pack

Expected:
Pack successfull no warnings

Actual:
Content files warnings displayed:

1>------ Build started: Project: MyClassLibrary, Configuration: Debug Any CPU ------
1>MyClassLibrary -> C:\Users\pakrym\Documents\Visual Studio 2017\Projects\MyClassLibrary\MyClassLibrary\bin\Debug\netstandard1.4\MyClassLibrary.dll
1>MyClassLibrary -> C:\Users\pakrym\Documents\Visual Studio 2017\Projects\MyClassLibrary\MyClassLibrary\bin\Debug\net451\MyClassLibrary.dll
1>MyClassLibrary -> C:\Users\pakrym\Documents\Visual Studio 2017\Projects\MyClassLibrary\MyClassLibrary\bin\Debug\netcoreapp1.1\MyClassLibrary.dll
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(89,5): warning : Issue found with package 'MyClassLibrary'.
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(89,5): warning : Issue: Assembly outside lib folder.

MORE WARNINGS _-- SEE VSFEEDBACK ISSUE

@rohit21agrawal

This comment has been minimized.

Show comment
Hide comment
@rohit21agrawal

rohit21agrawal Jan 25, 2017

Contributor

Investigated this and found out that the reason this happens is because VS UI actually calls msbuild /p:GeneratePackageOnBuild=true under the hood when a user right clicks a project -> Pack.

as a result, Pack was being called after each inner build. However, this will be fixed by :

NuGet/NuGet.Client#1148

Contributor

rohit21agrawal commented Jan 25, 2017

Investigated this and found out that the reason this happens is because VS UI actually calls msbuild /p:GeneratePackageOnBuild=true under the hood when a user right clicks a project -> Pack.

as a result, Pack was being called after each inner build. However, this will be fixed by :

NuGet/NuGet.Client#1148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment