Nomination fails in multi-TFM projects due to version default differences between netfx and netstandard projects #4419

Closed
alpaix opened this Issue Jan 27, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@alpaix

alpaix commented Jan 27, 2017

Problem
In certain hybrid VS solutions containing .NET Core and UWP projects default $(Version) differs between TFMs which causes nomination validation to fail. For instance, netstandard1.4 uses “1.0.0” as a default version while net46 returns "1.0.0.0."

Expected
NuGet is able to parse version value first before comparing actual values.

@alpaix alpaix self-assigned this Jan 27, 2017

@alpaix alpaix added this to the 4.0 RTM milestone Jan 30, 2017

alpaix added a commit to alpaix/NuGet.Client that referenced this issue Feb 1, 2017

Compare parsed versions when validating $(PackageVersion)
Resolves NuGet/Home#4419.

This change enhances the validation method of global non-evaluated properties that must not differ between different TFMs.

`VsSolutionRestoreService` will attempt to parse property values of `$(PackageVersion)` and `$(Version)` before eliminating duplicates in a list of properties retrieved for each TFM.

alpaix added a commit to alpaix/NuGet.Client that referenced this issue Feb 1, 2017

Compare parsed versions when validating $(PackageVersion)
Resolves NuGet/Home#4419.

This change enhances the validation method of global non-evaluated properties that must not differ between different TFMs.

`VsSolutionRestoreService` will attempt to parse property values of `$(PackageVersion)` and `$(Version)` before eliminating duplicates in a list of properties retrieved for each TFM.

@alpaix alpaix referenced this issue in dotnet/project-system Feb 3, 2017

Closed

VS doesn't restore on build/rebuild #1447

@rrelyea rrelyea changed the title from Nomination fails in multi-TFM projects to Nomination fails in multi-TFM projects due to version default differences between netfx and netstandard projects Sep 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment