When migrating to PackageRef, hybrid solutions have strange restore behavior #4433

Closed
rrelyea opened this Issue Jan 30, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@rrelyea
Contributor

rrelyea commented Jan 30, 2017

vs feedback using RC3 -- vsfeedback number 747888

Opened existing VSIX project (targetting VS 2012 to 2015)
Project upgraded to support 2017
Removed existing EnvDTE references and started to replace them with NuGet package references
Added EnvDTE package successfully (chose to use PackageReferences instead of packages.config file)

Tried to add EnvDTE80 package, but getting this error:

System.ArgumentException: Value cannot be null or an empty string.
Parameter name: name
at NuGet.PackageManagement.VisualStudio.ProjectSystemCache.ContainsKey(String name)
at NuGet.PackageManagement.VisualStudio.VSSolutionManager.RemoveEnvDTEProjectFromCache(String name)
at NuGet.PackageManagement.VisualStudio.VSSolutionManager.d__57.MoveNext()

@jainaashish

This comment has been minimized.

Show comment
Hide comment
@jainaashish

jainaashish Jan 31, 2017

Contributor

I can repro it locally, and we should fix it.

Contributor

jainaashish commented Jan 31, 2017

I can repro it locally, and we should fix it.

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Feb 9, 2017

Contributor

Since we've gotten more hits, want to decrease customer pain, and noise to our team by fixing this. Will discuss today at shiprooms.

Contributor

rrelyea commented Feb 9, 2017

Since we've gotten more hits, want to decrease customer pain, and noise to our team by fixing this. Will discuss today at shiprooms.

@rrelyea rrelyea changed the title from Exception trying to add EnvDTE80 NuGet Package while upgrading VSIX Project to When migrating to PackageRef, hybrid solutions have strange restore behavior Feb 9, 2017

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Feb 9, 2017

Contributor

Please finish PR review/feedback (if any).
Then ensure you've tested it all it needs.
Then, we'll review it with @DoRonMotter .
if he approves, then merge into dev.

Contributor

rrelyea commented Feb 9, 2017

Please finish PR review/feedback (if any).
Then ensure you've tested it all it needs.
Then, we'll review it with @DoRonMotter .
if he approves, then merge into dev.

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Feb 10, 2017

Contributor

Please merge into dev

Contributor

rrelyea commented Feb 10, 2017

Please merge into dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment