Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically use PackageReference mode if referencing a project that uses PackageReference #4581

Open
dsplaisted opened this issue Feb 12, 2017 · 9 comments

Comments

@dsplaisted
Copy link

@dsplaisted dsplaisted commented Feb 12, 2017

I'm not sure how feasible this is, but we have a really poor experience referencing .NET Standard projects from .NET Framework projects today:

  • Create a .NET Standard Library project
  • Create a .NET Framework Console app
  • Reference the .NET Standard Library from the Console app
  • Get FileNotFoundException at runtime, depending on what APIs you use

Here are issues I've found that people have filed after running into this:

dotnet/standard#202
dotnet/sdk#757
dotnet/sdk#766
dotnet/sdk#747
dotnet/standard#192

Issue #4488 now tracks a way to opt-in to PackageReference mode without havinng any PackageReference items in a project. However, you would have to know to opt in, so this would still be a common pit of failure.

Ideally, we could automatically detect when a project references another project that's in PackageReference mode, and automatically use PackageReference mode in the referencing project. We might be able to return metadata from one of the targets that's called on project references to help with this. However, by the time we call that target it might be too late- we may need to decide on the restore mode before then. If that's the case then it could still be helpful to generate an error or warning letting people know how to opt in to PackageReference mode.

@nguerrera @rainersigwald for feedback on how we could pass this information between projects as metadata

@rrelyea @emgarten for general FYI

@emgarten

This comment has been minimized.

Copy link
Member

@emgarten emgarten commented Feb 13, 2017

Restore could determine this, it always finds the full project to project reference graph and the restore style of each project.

However, wouldn't changing the behavior of an existing project to flow all references to it transitively be somewhat unexpected and possibly breaking? There would also be the scenario where the parent project uses packages.config and can't just switch over to using an assets file.

@rainersigwald

This comment has been minimized.

Copy link

@rainersigwald rainersigwald commented Feb 13, 2017

Yeah, sounds like this would be best as a clear error rather than an unexpected behavior change. There may already be metadata on the returned reference items that would be good enough to fuel that in the referencing project.

@rrelyea rrelyea added the Type:Bug label Feb 13, 2017
@rrelyea

This comment has been minimized.

Copy link
Contributor

@rrelyea rrelyea commented Feb 13, 2017

Yes, experience needs thought/design. Consider post RTM.

@rrelyea rrelyea added Type:DCR and removed Type:Bug labels Feb 13, 2017
@dsplaisted

This comment has been minimized.

Copy link
Author

@dsplaisted dsplaisted commented Feb 14, 2017

I wouldn't call this a breaking change for pre-VS2017 projects, because the behavior wouldn't change at all until you reference a project that uses PackageReference, which is something that didn't exist before. Of course since we can't do this for VS 2017 RTM we would still have to think about the impact it would have on projects created with VS 2017.

In general I agree with Rob that we need more thought and design for this. I do think it's important that we try to do something to improve the experience here.

@Code-ScottLe

This comment has been minimized.

Copy link

@Code-ScottLe Code-ScottLe commented Sep 22, 2017

Sorry for digging this up again, but do we have a plan to cure this problem yet? Running into this with Standard 1.4 and Unit Test Project (4.6.1) ATM and haven't figured out a good workaround yet.

@cesaralc

This comment has been minimized.

Copy link

@cesaralc cesaralc commented Oct 23, 2017

Is there a fix or a workaround for this?

@emgarten

This comment has been minimized.

Copy link
Member

@emgarten emgarten commented Oct 23, 2017

@cesaralc

<PropertyGroup>
  <RestoreProjectStyle>PackageReference</RestoreProjectStyle>
</PropertyGroup>
@onovotny

This comment has been minimized.

Copy link

@onovotny onovotny commented Jan 8, 2018

This also affects Xamarin projects referencing libraries that use PackageReference but where the Xamarin "head" projects do not have any PackageReferences of their own.

@mj1856

This comment has been minimized.

Copy link

@mj1856 mj1856 commented Mar 16, 2018

This issue seems to be tracked in dotnet/standard#481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.