NuGet restore in Visual Studio does not respect PackageId property of projects #4586

Closed
rrelyea opened this Issue Feb 13, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@rrelyea
Contributor

rrelyea commented Feb 13, 2017

Need to determine customer impact, importance for RTM vs 4.0.1

NuGet side of: dotnet/project-system#1532

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Feb 16, 2017

Contributor

Confirm that PackageId could go in the property bag per TFM. Confirm impact on customer. Restore works in VS, but cannot pack reliably from that restore graph? or worse?

Contributor

rrelyea commented Feb 16, 2017

Confirm that PackageId could go in the property bag per TFM. Confirm impact on customer. Restore works in VS, but cannot pack reliably from that restore graph? or worse?

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Feb 17, 2017

Contributor

Communicated to rps (via linked issue above) that we'd try to take if they can pass the data.

Contributor

rrelyea commented Feb 17, 2017

Communicated to rps (via linked issue above) that we'd try to take if they can pass the data.

@alpaix alpaix self-assigned this Feb 21, 2017

@rrelyea rrelyea removed their assignment Feb 21, 2017

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Feb 21, 2017

Contributor

From email:
Looks like Nat is preparing the Roslyn-Project-System side of this fix.
@alpaix – Can you please prepare the change to harvest and apply?

Contributor

rrelyea commented Feb 21, 2017

From email:
Looks like Nat is preparing the Roslyn-Project-System side of this fix.
@alpaix – Can you please prepare the change to harvest and apply?

alpaix added a commit to alpaix/NuGet.Client that referenced this issue Feb 22, 2017

Support for PackageId in .NET Core project system
Resolve NuGet/Home#4586.

Retrieve `PackageId` global un-evaluated property from the
`ProjectRestoreInfo` on RPS nomination. Assign the value to
`PackageSpec.Name` attribute. Use `ShortName` if the property is not
defined (current behavior).

alpaix added a commit to NuGet/NuGet.Client that referenced this issue Feb 24, 2017

Support for PackageId in .NET Core project system
Resolve NuGet/Home#4586.

Retrieve `PackageId` global un-evaluated property from the
`ProjectRestoreInfo` on RPS nomination. Assign the value to
`PackageSpec.Name` attribute. Use `ShortName` if the property is not
defined (current behavior).

@smadala smadala referenced this issue in Microsoft/vstest Mar 9, 2017

Closed

No xunit tests discovered in netcoreapp1.0 #576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment