New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet add tool #4901

Open
livarcocc opened this Issue Mar 27, 2017 · 25 comments

Comments

Projects
None yet
@livarcocc

livarcocc commented Mar 27, 2017

From @shanselman on March 27, 2017 4:10

I wish we could

dotnet add tool DotnetWatcher:1.0.0

and get

<ItemGroup>
 <DotNetCliToolReference Include="Microsoft.DotNet.Watcher.Tools" Version="1.0.0" />
</ItemGroup>

Copied from original issue: dotnet/cli#6156

@awesley

This comment has been minimized.

awesley commented Apr 30, 2017

I request that this get prioritized as there are a good number of people producing documentation and tutorials on dotnet core with comments like "copy this csproj file". Alleviating this problem early will improve the quality of education material related to .NET core and the tooling surrounding it.

@MaximRouiller

This comment has been minimized.

MaximRouiller commented May 23, 2017

Is there any progress?

@mishra14

This comment has been minimized.

Collaborator

mishra14 commented May 24, 2017

@rrelyea do we have a plan for this?

@rrelyea rrelyea added this to the Future-0 milestone May 24, 2017

@rrelyea

This comment has been minimized.

Contributor

rrelyea commented May 24, 2017

Sorry, cannot land 4.3 with this work done.

@MaximRouiller

This comment has been minimized.

MaximRouiller commented May 25, 2017

@rrelyea So this goes into the "we want to do it but don't have the time right now" bucket?

@johnkors

This comment has been minimized.

johnkors commented May 26, 2017

Sorry, cannot land 4.3 with this work done.

Not sure I understand that sentence. :| Do you mean it'll have to wait, @rrelyea ?

@shanselman

This comment has been minimized.

shanselman commented May 30, 2017

If I did a PR could it be done? Or are there too many moving parts?

@ibqn

This comment has been minimized.

ibqn commented Aug 12, 2017

what is the status here? This one moves forward very slowly

@wholroyd

This comment has been minimized.

wholroyd commented Aug 13, 2017

Also interested in seeing this happen

@rrelyea rrelyea modified the milestones: Backlog, 4.4 Aug 15, 2017

@rrelyea rrelyea added the Priority:1 label Aug 15, 2017

@rrelyea

This comment has been minimized.

Contributor

rrelyea commented Aug 15, 2017

Properly putting it in the backlog as 4.4 didn't happen as we hoped. @mishra14 wants to do this badly. Just need to clear his plate of other critical things.

@fyn-dev

This comment has been minimized.

fyn-dev commented Oct 11, 2017

Yes me too. I really need this feature.

@ertw

This comment has been minimized.

ertw commented Oct 11, 2017

I'd like to add that as a new user to .net core, this was a real blocker for me. I spent a long time trying to run dotnet ef, and the error messages from trying to run that command and from trying to add other packages were not clear, and didn't really point me in the correct direction. Also, most documentation still references project.json, making this even more confusing.

@shanselman

This comment has been minimized.

shanselman commented Oct 12, 2017

@KathleenDollard @rrelyea How we doing on this? Feels like just a day of someone's time. I'd do it if I could get this repo to build.

@mishra14

This comment has been minimized.

Collaborator

mishra14 commented Oct 12, 2017

@shanselman what issues are you having in building the repo?

@mishra14

This comment has been minimized.

Collaborator

mishra14 commented Oct 12, 2017

@ertw Can you please point us to documentation that you are referring to? I can look at getting ti fixed.

@ertw

This comment has been minimized.

ertw commented Oct 12, 2017

@mishra14 The out of date information I found mostly came from old MSDN posts and private bloggers. The canonical tutorial for EF (https://docs.microsoft.com/en-us/ef/core/get-started/netcore/new-db-sqlite) is up to date and in wiki form, so something I can edit as well if I find anything wrong. I'll let you know if I find any more Microsoft resources that are incorrect.

@evil-shrike

This comment has been minimized.

evil-shrike commented Oct 19, 2017

Some more complains:
It's very unclear what is the point in marking a nuget package as cli tool if it's totally ignored on installing by nuget and dotnet-cli:
I mean that if a DotnetCliTool-package with nuspec:

    <packageTypes>
      <packageType name="DotnetCliTool" />
    </packageTypes>

installed via dotnet add package will get into PackageReference as normal nuget package. And dotnet <tool> will not find it.
If we have to tell dotnet explicitly that a package is a cli-tool via DotNetCliToolReference in csproj why then we have to set packageType for that package?

But anyway. If such a notion as "custom cli tool" was introduced it should be supported by dotnet for installing. It's a must. Isn't it so hard to implement?

What's the point in distributing nuget packages with cli tools if while installed in common way they won't work?!

@cottsak

This comment has been minimized.

cottsak commented Jan 24, 2018

Doco at https://github.com/aspnet/DotNetTools says dotnet install tool dotnet-watch but with 2.4.1 it's still not working.

Instructions here still show manually installation. 😢

@dasMulli

This comment has been minimized.

dasMulli commented Jan 24, 2018

@cottsak the syntax now changed to dotnet install tool -g {something} and you'd need a preview tooling that is at least 2.1.300-preview1-*. This isn't part of any released tooling yet.

@fcavaco

This comment has been minimized.

fcavaco commented Mar 6, 2018

@dasMulli , fine went through that and I am using 2.1.300-preview1-* SDK, nevertheless, it still does not add the tool in the project file as DotNetCliToolReference. talking about dotnet-watch for example. while creating a solution using shell script this forces me to manually edit the csproj file to add that reference still. as someone said before , if the package type is marked as a tool, that should suffice to add both entries in the proj file.

@KirkMunro

This comment has been minimized.

KirkMunro commented Jul 21, 2018

Any update on this?

@dasMulli

This comment has been minimized.

dasMulli commented Jul 21, 2018

Is this still needed? DotNetCliToolReference is de-facto deprecated now with global tools.. (though some scenarios involving project or solution specific tools / versions still being thought about)

@KirkMunro

This comment has been minimized.

KirkMunro commented Jul 23, 2018

Probably not. I came here looking for it because I was working through an ASP.NET Core 2.1 tutorial, but that tutorial needs updating so I think my issue was simply symptomatic of an out of date tutorial.

@shanselman

This comment has been minimized.

shanselman commented Jul 23, 2018

@KirkMunro which tutorial?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment