New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate language for NU1212 #6630

Open
KathleenDollard opened this Issue Mar 1, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@KathleenDollard
Copy link

KathleenDollard commented Mar 1, 2018

And example of the current text for error NU1212:

Invalid project-package combination for Microsoft.DotNet.Watcher.Tools 2.0.0. DotnetToolReference project style can only contain references of the DotnetTool type

This text appears when a user incorrectly attempts to install an old style tool with the new experience. This is likely to occur and the message is not helpful.

Can we adjust this language to something like:

The requested package does not have the expected DotnetTool type and can't be used where that type is expected. For example, this package can't be used with "dotnet install tool -g"

@natemcmaster for opinion on this text

@natemcmaster

This comment has been minimized.

Copy link

natemcmaster commented Mar 1, 2018

I think you could drop the part of the error that says "For example, this package can't be used with "dotnet install tool -g".

@KathleenDollard

This comment has been minimized.

Copy link

KathleenDollard commented Mar 1, 2018

OK, I'm good with dropping that clause as @natemcmaster suggests. It does feel a bit funny, I was just going for clarity in the context we'll use it.

@nkolev92 nkolev92 self-assigned this Mar 1, 2018

@nkolev92 nkolev92 added this to the Backlog milestone Mar 1, 2018

@nkolev92 nkolev92 added the Priority:0 label Mar 1, 2018

@nkolev92

This comment has been minimized.

Copy link
Member

nkolev92 commented Mar 1, 2018

The message is such, because it's used for both the case when a tool package is added to a regular package reference project, and the case when a non-tool package is attempted to be restored as a tool.

I'll look into how I can change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment