Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The serialization of GetAuthenticationCredentialRequest is incorrect #6983

Closed
nkolev92 opened this issue May 30, 2018 · 1 comment
Closed

The serialization of GetAuthenticationCredentialRequest is incorrect #6983

nkolev92 opened this issue May 30, 2018 · 1 comment
Assignees
@nkolev92
Labels
Area:Authentication Area:Plugin V2 plugin w/ cross platform support Type:Bug
Milestone
4.8

Comments

@nkolev92
Copy link
Member

In the code review, the parameter name in the constructor was changed, but the property wasn't.

This means that isNonInteractive will always be false.

https://github.com/NuGet/NuGet.Client/blob/3db1528ee90a4858f620362bf49876099c8e5f67/src/NuGet.Core/NuGet.Protocol/Plugins/Messages/GetAuthenticationCredentialsRequest.cs#L30

https://github.com/NuGet/NuGet.Client/blob/3db1528ee90a4858f620362bf49876099c8e5f67/src/NuGet.Core/NuGet.Protocol/Plugins/Messages/GetAuthenticationCredentialsRequest.cs#L40
@nkolev92 nkolev92 added Type:Bug Area:Authentication Area:Plugin V2 plugin w/ cross platform support labels May 30, 2018
@nkolev92 nkolev92 added this to the 4.8 milestone May 30, 2018
@nkolev92 nkolev92 added Cost 5 and removed Cost 5 labels May 30, 2018
@nkolev92 nkolev92 mentioned this issue May 30, 2018
Merged
@nkolev92 nkolev92 changed the title Fix the serialization of GetAuthenticationCredentialRequest The serialization of GetAuthenticationCredentialRequest is incorrect May 30, 2018
@nkolev92 nkolev92 mentioned this issue May 30, 2018
Closed
17 tasks
@nkolev92 nkolev92 self-assigned this May 30, 2018
@nkolev92
Copy link
Member Author

nkolev92 commented Jun 4, 2018

NuGet/NuGet.Client@1645951

@nkolev92 nkolev92 closed this as completed Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Area:Authentication Area:Plugin V2 plugin w/ cross platform support Type:Bug
Projects
None yet
Milestone
4.8
Development

No branches or pull requests
1 participant
@nkolev92