New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking changes in NuGet.Protocol package version 4.9 #7593

Closed
AnthonySteele opened this Issue Dec 5, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@AnthonySteele

AnthonySteele commented Dec 5, 2018

When updating the package NuGet.Protocol to 4.9.1 from 4.8, there are a few things that break. I am not aware of any docs on how to fix.

Particularly I see the property PackageSource.Origin has gone.
And NuGet.Configuration.Settings.ISettings no longer has the property Priority.

This fails at compile-time after the minor version update.

@nkolev92 nkolev92 added the NuGet API label Dec 5, 2018

@nkolev92

This comment has been minimized.

Member

nkolev92 commented Dec 5, 2018

//cc @PatoBeltran would have context.

@AnthonySteele

This comment has been minimized.

AnthonySteele commented Dec 5, 2018

Is this code equivalent? NuKeeperDotNet/NuKeeper#587

@nkolev92

This comment has been minimized.

Member

nkolev92 commented Dec 5, 2018

@AnthonySteele It looks fine to me, but @PatoBeltran would know for sure if the order is correct there. (Not sure if it's relevant for your case however)

@PatoBeltran

This comment has been minimized.

PatoBeltran commented Dec 5, 2018

Hey @AnthonySteele, sorry that we broke you with these changes. While improving the NuGet.Configuration we tried to change as little as possible, but unfortunately Priority is one of the things that did change.

The change you point out in your PR is the perfect solution. The only difference between your previous code and this one is that we do a Path.GetFullPath(...) on the combined path (https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Core/NuGet.Configuration/Settings/Settings.cs#L584)

@nkolev92

This comment has been minimized.

Member

nkolev92 commented Dec 10, 2018

Apologies again for breaking your build again, while we do our best not to, sometimes these changes are unavoidable, after all, NuGet.Client is a tool first.

@nkolev92 nkolev92 closed this Dec 10, 2018

@AnthonySteele

This comment has been minimized.

AnthonySteele commented Dec 11, 2018

I understand that breaking changes are inevitable, but they are not expected in a minor version update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment