New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'dotnet restore' enumerates local package sources for MSBuild project sdk packages already in the packages cache #7594

Open
bergbria opened this Issue Dec 5, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@bergbria

bergbria commented Dec 5, 2018

Details about Problem

dotnet.exe --version: 2.2.100

Suppose I have a .csproj that lists a nuget-based MSBuild sdk and that I've already run 'dotnet restore.' The sdk package will be installed to my packages cache. Theoretically, if I re-run restore, it will realize the package is already cached and not bother looking on my package sources.

However, the second restore will indeed look on my package sources. This is a needless performance hit, magnified if I'm using slow-to-respond source (e.g. a network share)

Detailed repro steps so we can see the same problem

  1. Unzip restore_unneeded_enumeration.zip to your machine somewhere

  2. Ensure procmon is available for use on your machine

  3. Run [unzip dir]\repro.bat. It will provide instructions/context as it progresses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment