New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultipartWebRequest::CreateMultipartRequest should use "\r\n" explicitly and not Environment.NewLine #776

Closed
bradbeck opened this Issue Jun 12, 2015 · 2 comments

Comments

Projects
None yet
6 participants
@bradbeck

bradbeck commented Jun 12, 2015

MultipartWebRequest::CreateMultipartRequest line 63 should use "\r\n" explicitly and not Environment.NewLine in order adhere to the multipart content-type spec. When running nuget on unix via mono this causes nuget push ... operations to fail because the resulting PUT requests are malformed.

Reference: http://stackoverflow.com/questions/30807139/mono-nuget-exe-push-produces-invalid-multipart-put-request

@bradbeck bradbeck changed the title from MultipartWebRequest::CreateMultipartRequest should us "\r\n" explicitly and to Environment.NewLine to MultipartWebRequest::CreateMultipartRequest should us "\r\n" explicitly and not Environment.NewLine Jun 12, 2015

@yishaigalatzer yishaigalatzer added this to the 3.0.0-commandline milestone Jun 12, 2015

@deepakaravindr deepakaravindr modified the milestones: 3.2.0-commandline, 3.1.0-commandline Jul 23, 2015

@deepakaravindr deepakaravindr modified the milestones: 3.1.0-commandline, 3.2.0-commandline Aug 6, 2015

@feiling feiling added the 2 - Working label Aug 12, 2015

@bradbeck bradbeck changed the title from MultipartWebRequest::CreateMultipartRequest should us "\r\n" explicitly and not Environment.NewLine to MultipartWebRequest::CreateMultipartRequest should use "\r\n" explicitly and not Environment.NewLine Aug 12, 2015

feiling pushed a commit to NuGetArchive/NuGet.PackageManagement that referenced this issue Aug 13, 2015

feiling
Fix NuGet/Home#776: MultipartWebRequest::CreateMultipartRequest shoul…
…d us "\r\n" explicitly and not Environment.NewLine

feiling pushed a commit to NuGet/NuGet2 that referenced this issue Aug 13, 2015

feiling
Fix NuGet/Home#776: MultipartWebRequest::CreateMultipartRequest shoul…
…d us "\r\n" explicitly and not Environment.NewLine

feiling pushed a commit to NuGet/NuGet2 that referenced this issue Aug 13, 2015

feiling
Fix NuGet/Home#776: MultipartWebRequest::CreateMultipartRequest shoul…
…d us "\r\n" explicitly and not Environment.NewLine
@feiling

This comment has been minimized.

Show comment
Hide comment
@feiling

feiling Aug 14, 2015

Code fix checked into NuGet.V2.

feiling commented Aug 14, 2015

Code fix checked into NuGet.V2.

feiling pushed a commit to NuGetArchive/NuGet3 that referenced this issue Aug 17, 2015

feiling pushed a commit to NuGetArchive/NuGet3 that referenced this issue Aug 18, 2015

@feiling

This comment has been minimized.

Show comment
Hide comment
@feiling

feiling Aug 19, 2015

Dependency updated in nuget v3 so that nuget v3 command line is also fixed.

feiling commented Aug 19, 2015

Dependency updated in nuget v3 so that nuget v3 command line is also fixed.

@feiling feiling closed this Aug 19, 2015

@Knele83

This comment has been minimized.

Show comment
Hide comment
@Knele83

Knele83 Aug 19, 2015

lbipzelccvvypsgq

Knele83 commented Aug 19, 2015

lbipzelccvvypsgq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment