MultipartWebRequest::CreateMultipartRequest should use "\r\n" explicitly and not Environment.NewLine #776

Closed
bradbeck opened this Issue Jun 12, 2015 · 2 comments

Projects

None yet

6 participants

@bradbeck

MultipartWebRequest::CreateMultipartRequest line 63 should use "\r\n" explicitly and not Environment.NewLine in order adhere to the multipart content-type spec. When running nuget on unix via mono this causes nuget push ... operations to fail because the resulting PUT requests are malformed.

Reference: http://stackoverflow.com/questions/30807139/mono-nuget-exe-push-produces-invalid-multipart-put-request

@bradbeck bradbeck changed the title from MultipartWebRequest::CreateMultipartRequest should us "\r\n" explicitly and to Environment.NewLine to MultipartWebRequest::CreateMultipartRequest should us "\r\n" explicitly and not Environment.NewLine Jun 12, 2015
@yishaigalatzer yishaigalatzer added this to the 3.0.0-commandline milestone Jun 12, 2015
@feiling feiling added the 2 - Working label Aug 12, 2015
@bradbeck bradbeck changed the title from MultipartWebRequest::CreateMultipartRequest should us "\r\n" explicitly and not Environment.NewLine to MultipartWebRequest::CreateMultipartRequest should use "\r\n" explicitly and not Environment.NewLine Aug 12, 2015
@feiling feiling added a commit to NuGetArchive/NuGet.PackageManagement that referenced this issue Aug 13, 2015
@feiling feiling Fix NuGet/Home#776: MultipartWebRequest::CreateMultipartRequest shoul…
…d us "\r\n" explicitly and not Environment.NewLine
8c89351
@feiling feiling added a commit to NuGet/NuGet2 that referenced this issue Aug 13, 2015
@feiling feiling Fix NuGet/Home#776: MultipartWebRequest::CreateMultipartRequest shoul…
…d us "\r\n" explicitly and not Environment.NewLine
195da62
@feiling feiling added a commit to NuGet/NuGet2 that referenced this issue Aug 13, 2015
@feiling feiling Fix NuGet/Home#776: MultipartWebRequest::CreateMultipartRequest shoul…
…d us "\r\n" explicitly and not Environment.NewLine
fbb8085
@feiling
Contributor
feiling commented Aug 14, 2015

Code fix checked into NuGet.V2.

@feiling feiling added a commit to NuGetArchive/NuGet3 that referenced this issue Aug 17, 2015
@feiling feiling Update the dependency on NuGet.Core to 2.8.8 so that the fix of NuGet…
…/Home#776 gets incorporated into nuget v3.
e640df1
@feiling feiling added a commit to NuGetArchive/NuGet3 that referenced this issue Aug 18, 2015
@feiling feiling Update the dependency on NuGet.Core to 2.8.8 so that the fix of NuGet…
…/Home#776 gets incorporated into nuget v3.
1393045
@feiling
Contributor
feiling commented Aug 19, 2015

Dependency updated in nuget v3 so that nuget v3 command line is also fixed.

@feiling feiling closed this Aug 19, 2015
@Knele83
Knele83 commented Aug 19, 2015

lbipzelccvvypsgq

@feiling feiling added 3 - Done and removed 2 - Working labels Sep 1, 2015
@feiling feiling removed their assignment Sep 1, 2015
@csharpfritz csharpfritz modified the milestone: 2.8.8, 3.2.0-commandline, 3.2 Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment