Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeneratePathProperty=true fails to generate property on case mismatch #7843

Closed
ericstj opened this Issue Mar 1, 2019 · 6 comments

Comments

Projects
None yet
4 participants
@ericstj
Copy link
Collaborator

ericstj commented Mar 1, 2019

Details about Problem

NuGet product used (NuGet.exe | VS UI | Package Manager Console | dotnet.exe): dotnet.exe

NuGet version (x.x.x.xxx): 5.0.0.1

dotnet.exe --version (if appropriate): 3.0.100-preview-010142

VS version (if appropriate): n/a

OS version (i.e. win10 v1607 (14393.321)): win10 v1809 (17763.195)

Worked before? If so, with which NuGet version: no

Detailed repro steps so we can see the same problem

  1. Use attached project.

  2. dotnet build, observe PkgSystemMemory = C:\Users\user\.nuget\packages\system.memory\4.5.2

  3. dotnet build /p:Repro=true, observe PkgSystemMemory =

I believe the bug is here: https://github.com/NuGet/NuGet.Client/pull/2271/files#r261694951

nugetCase.zip

ericstj added a commit to ericstj/corefx that referenced this issue Mar 1, 2019

ericstj added a commit to dotnet/corefx that referenced this issue Mar 1, 2019

Remove InitTools and ToolsDir (#35677)
* Remove buildtools init-tools and various BuildTools specific properties

* Workaround NuGet restore GeneratePathProperty case-sensitivity

See NuGet/Home#7843

@rrelyea rrelyea added this to the 5.1 milestone Mar 5, 2019

@rrelyea

This comment has been minimized.

Copy link
Contributor

rrelyea commented Mar 5, 2019

Happy to talk, if you think there are issues with this approach. Let's target 5.1, if your question was just about milestone.

@nkolev92

This comment has been minimized.

Copy link
Member

nkolev92 commented Mar 6, 2019

@jeffkl Already has a PR out for this and it looks good.
I'll merge once the tests pass.

@anangaur

This comment has been minimized.

Copy link
Member

anangaur commented Mar 19, 2019

@nkolev92, Is this feature documented somewhere? I couldn't find an issue that summarizes what we did finally?

@nkolev92

This comment has been minimized.

Copy link
Member

nkolev92 commented Mar 19, 2019

@anangaur It wasn't publicly advertised on purpose iirc.

Basically no, there's no documentation, it's just the issue. It should probably have been summarized in a desgin doc at the least however.

@anangaur

This comment has been minimized.

Copy link
Member

anangaur commented Mar 19, 2019

Can you just create an issue on docs repo? Seems like an interesting and useful property.

@nkolev92

This comment has been minimized.

Copy link
Member

nkolev92 commented Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.