Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade fails with "Unable to find metadata of <somepackageid>" if a package is in fallback folder, but not remote feed #7881

Open
rrelyea opened this Issue Mar 15, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@rrelyea
Copy link
Contributor

rrelyea commented Mar 15, 2019

PackageA v2
depends on
PackageB v3
Those 2 packages are in a fallback folder only.

Upgrade Package A to v4

PackageA v4
depends on
PackageB v5
Those 2 packages are not in the fallback folder, but are available in a package feed.

Believe an error message is raised from UIActionEngine - line 806.
At first look, it looks like, for licensing dialog reasons, we are trying to find out if the full set of packages require license acceptance or not.
We cannot get all the metadata -- likely because PackageB v3 isn't on any feeds.

Likely, we should support getting nuspec from fallback folder too?
Why do we care about the old version license? (to not ask, if already approved, and license hasn't changed???)

This happened in a real scenario with some UWP packages.
Was told this reproed with 15.9, but not 16.0.

@rrelyea rrelyea self-assigned this Mar 15, 2019

@rrelyea rrelyea added this to the 5.1 milestone Mar 15, 2019

@rrelyea

This comment has been minimized.

Copy link
Contributor Author

rrelyea commented Mar 15, 2019

My impression is that 15.9 was testing update from 6.2.3 to 6.2.8 of the main UWP package.
16.0 was testing update from 6.2.7 to 6.2.8 of the same package.

A) in the 15.9 case for 6.2.3, there were ~21 package updates.
B & C)While moving from 6.2.7 to 6.2.8 in 15.9 or 16.0, there were only 12 package updates.

In order to show license info, nuget needs to get metadata (nuspec) for each package.
In case A - 9 of the package updates needed to be fetched from online feeds.
The one package that failed to be published there was part of that set of 9.

This has been worked around by publishing the package to nuget.org.

It appears that the license codepath didn't know aboutthe uwp fallback folder.
This is likely because the uwp fallback folder is set via msbuild props/targets.
The xamarin fallback folder is set via nuget.config, and would have worked in this case.

Things to investigate/consider:

  1. the update preview found the package in the fallback folder, but the license check did not. why is this different?
  2. etc...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.