Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow package authors to define build assets transitive behavior in VS 2017 / NuGet 4.x #7961

Open
karann-msft opened this issue Apr 4, 2019 · 7 comments

Comments

@karann-msft
Copy link
Contributor

@karann-msft karann-msft commented Apr 4, 2019

source: https://twitter.com/dotMorten/status/1113867687266881536

Same as #6091 but for VS 2017 / NuGet 4.x

@rrelyea
Copy link
Contributor

@rrelyea rrelyea commented Apr 5, 2019

Assigning Milestone, but not yet planning to do.
Should we port this to 4.9.x codebase and ship as an update of VS and dotnet SDKs?

@dotMorten
Copy link

@dotMorten dotMorten commented Apr 20, 2019

Hard yes please. I see a big problem with a code base that compiles and runs fine on VS2019, but either fails to compile or crashes at runtime on VS2017 because this feature isn't there. For instance libraries like Microsoft-UI-Xaml, Xamarin.Forms or ArcGIS Runtime rely on build targets to execute correctly, and having transitive builds work "right" makes things much easier when working with .NET Standard libraries and don't have to remember to also add all the dependencies once again to the app heads.

@ericsampson
Copy link

@ericsampson ericsampson commented Mar 13, 2020

@dotMorten seems like this got canceled from VS 15.9.x servicing?

@dotMorten
Copy link

@dotMorten dotMorten commented Mar 13, 2020

@ericsampson huh? Where do you see that? The milestone is still 4.9.x

@ericsampson
Copy link

@ericsampson ericsampson commented Mar 15, 2020

@dotMorten from this comment, unless I misunderstood?
#8094 (comment)

@dotMorten
Copy link

@dotMorten dotMorten commented Mar 16, 2020

Ugh! I missed that. @rrelyea ???

@ericsampson
Copy link

@ericsampson ericsampson commented Mar 16, 2020

Yeah it’s definitely disappointing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.