Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve warning message when using licenseUrl #8000
Some customers do not find it obvious how to act on the warning. For example this VS feedback: https://developercommunity.visualstudio.com/content/problem/504915/nuget-package-license-warning-not-resolvable.html
It's easy to understand why customers seeing the following warning message:
believe it's possible to simply rename the
I suggest we change the URL in the NU5125 docs to a page that has clear, concise instruction on how to use embedded licenses, and we should also include the URL to those docs in the warning message for anyone using nuget.exe or the dotnet cli, since they won't have a clickable link like in the Visual Studio error list.
You want the warning message to contain a link to the warning docs?
I have a philosophical problem with that. We should not have hard links from the product.
I'd be open to enhancing the warning message without any hard links.
I'd imagine it's a tiny minority that'd interpret it as such, but yeah we should do our best to improve it.
I also have issues with the NU5125 docs, but I think it's easier/quicker for me to create a PR rather than explain it and wait for someone else to work on it. Basically, imagine you're a customer who saw the warning message and wants to migrate to the new, supported feature. The current docs require at least 2 more clicks to find actionable information, but there are 6 links and only 2 seem to have actionable information, so there's basically a 1/3 chance they'll find the info in 2 clicks.