Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify TargetFramework vs TargetFrameworks vs TargetFrameworkMoniker across the NuGet codebase. #8388

Closed
nkolev92 opened this issue Jul 27, 2019 · 2 comments
Closed

Clarify TargetFramework vs TargetFrameworks vs TargetFrameworkMoniker across the NuGet codebase. #8388

nkolev92 opened this issue Jul 27, 2019 · 2 comments
Assignees
@nkolev92
Labels
Functionality:Restore Partner:CLI-SDK Partner:MSBuild Partner:Project-System Priority:2 Issues for the current backlog. Product:NuGet.exe NuGet.exe Product:VS.Client Type:Bug
Milestone
Backlog

Comments

@nkolev92
Copy link
Member

nkolev92 commented Jul 27, 2019 •
edited

Discussion in #7717 (comment).

NuGet should align to whatever the rest of the build expects.
//cc @davkean @zivkan @rrelyea
@nkolev92 nkolev92 self-assigned this Jul 27, 2019
@nkolev92
Copy link
Member Author

nkolev92 commented Jul 27, 2019 •
edited

Refer to #7717 (comment) specifcally.
#7717 (comment)

@nkolev92 nkolev92 mentioned this issue Jul 27, 2019
Closed
@nkolev92 nkolev92 changed the title Clarify TargetFramework vs TargetFrameworks vs TargetFrameworkMoniker across the NUGet codebase. Clarify TargetFramework vs TargetFrameworks vs TargetFrameworkMoniker across the NuGet codebase. Jul 27, 2019
@michael-hawker michael-hawker mentioned this issue Nov 18, 2019
Closed
@nkolev92 nkolev92 added Sprint 163 Priority:2 Issues for the current backlog. and removed Triage:NeedsTriageDiscussion labels Dec 20, 2019
@nkolev92 nkolev92 added this to the Backlog milestone Dec 23, 2019
michael-hawker added a commit to CommunityToolkit/WindowsCommunityToolkit that referenced this issue Dec 23, 2019
@michael-hawker
Fixes #3012 working around NuGet/Home#8388
6b548da 
Tested with VS 2019 16.5 Preview 1
azchohfi added a commit to CommunityToolkit/WindowsCommunityToolkit that referenced this issue Dec 23, 2019
@azchohfi
Merge pull request #3084 from windows-toolkit/mhawker/fix-vs2019-build
7eb9c0b 
Fixes #3012 working around NuGet/Home#8388
@nkolev92 nkolev92 mentioned this issue Feb 18, 2020
Closed
@nkolev92
Copy link
Member Author

nkolev92 commented Mar 9, 2020

There's an old issue for this. Dup of #5154

@nkolev92 nkolev92 closed this as completed Mar 9, 2020
@Kyaa-dost Kyaa-dost mentioned this issue Nov 18, 2020
Closed
@nkolev92 nkolev92 mentioned this issue Feb 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Functionality:Restore Partner:CLI-SDK Partner:MSBuild Partner:Project-System Priority:2 Issues for the current backlog. Product:NuGet.exe NuGet.exe Product:VS.Client Type:Bug
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@nkolev92