Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Failure][Deprecation] Deprecated info of the deprecated package “test10k” will show on PM UI right pane with 30 seconds’ delay and VS hanging #8557

Closed
v-luzh opened this issue Sep 6, 2019 · 3 comments

Comments

@v-luzh
Copy link

@v-luzh v-luzh commented Sep 6, 2019

Details about Problem

NuGet version: NuGet Client Dev\5.3.0.6224
VS Version: D16.3\29305.141
OS: Windows-10-Enterprise-19H1-04-05-2019

Detailed repro steps

  1. Launch VS and create a project. [e.g. Console Application (.NET Core)]
  2. Add a deprecated package source: https://apidev.nugettest.org/v3-index/index.json.
  3. Open PM UI of the project, select the above deprecated package source and search the deprecated package “test10k” in Browse tab.
  4. Click the package on the left pane and look at the right pane.

Expected

Deprecated info of the package should show immediately.

Actual

Deprecated info of the deprecated package “test10k” will show on PM UI right pane with 30 seconds’ delay and VS hung when loading the deprecated info as below video.

DeprecationInfoDelay

@scottbommarito

This comment has been minimized.

Copy link

@scottbommarito scottbommarito commented Sep 6, 2019

The package "test10k" has 10,000 versions (more than any actual packages on nuget.org), and the hang is likely associated with that.

Furthermore, the hang also appears to reproduce on 5.2, without the changes for deprecation, so I do not believe this is a regression, although whether or not the hang has been worsened in any way by the changes is unclear to me.

As a side note, there are only around 250 or so package IDs on nuget.org with over 1,000 versions, and I believe there are <5 packages with 5,000 versions. I investigated a package with 1,000 versions and didn't reproduce the hang. I don't believe that this bug is very critical.

@v-luzh

This comment has been minimized.

Copy link
Author

@v-luzh v-luzh commented Sep 9, 2019

Yes, that's not a regression and not a critical bug. That's the reason why we didn't file it before. Base on our disccusion, we think the issue should be fixed somehow (reduce hanging time or prohibit customer making large version like that) since customer may run into it, although the probability is not high.

@scottbommarito scottbommarito removed their assignment Sep 9, 2019
@rrelyea rrelyea modified the milestones: 5.3, Backlog Oct 31, 2019
@nkolev92

This comment has been minimized.

Copy link
Member

@nkolev92 nkolev92 commented Jan 14, 2020

Closing this as dup of #8478.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.