Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Visual Studio NuGet packages (RestoreManagerPackage and NuGetPackage packages) needs to auto load on solution build events #8796

Open
nkolev92 opened this issue Nov 6, 2019 · 2 comments

Comments

@nkolev92
Copy link
Member

@nkolev92 nkolev92 commented Nov 6, 2019

See https://dev.azure.com/devdiv/DevDiv/_workitems/edit/792876.

From a thread:

We had a discussion on this and decided the proper way to do this is to whitelist the SolutionBuilding UI context for sync autoload.

After the UI context is whitelisted, nuget will have to add the following into the package definition:
[ProvideAutoLoad(VSConstants.UICONTEXT.SolutionBuilding_string)]

Note that there should be no PackageAutoLoadFlags.BackgroundLoad flag in this registration. Otherwise your package will be async autoloaded, causing the same issue. Note that you may also want to keep the existing autoload on solution exists, as that’s async autoload and helps the Build performance sometimes.

@nkolev92

This comment has been minimized.

Copy link
Member Author

@nkolev92 nkolev92 commented Nov 11, 2019

Duplicate issue in VSTS

@nkolev92

This comment has been minimized.

Copy link
Member Author

@nkolev92 nkolev92 commented Nov 11, 2019

Assigning to Rob as the internal issue is assigned to him.

@rrelyea rrelyea added the Sprint 162 label Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.