Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestoreSettingsUtils needs overload to use new SettingsLoadingContext #8855

Closed
jeffkl opened this issue Nov 25, 2019 · 1 comment · Fixed by NuGet/NuGet.Client#3139

Comments

@jeffkl
Copy link
Collaborator

@jeffkl jeffkl commented Nov 25, 2019

Details about Problem

The new SettingsLoadingContext needs to be added as an overload to RestoreSettingsUtils so that it can be used when reading the settings initially.

NuGet product used (NuGet.exe | VS UI | Package Manager Console | dotnet.exe):

NuGet version (x.x.x.xxx):

dotnet.exe --version (if appropriate):

VS version (if appropriate):

OS version (i.e. win10 v1607 (14393.321)):

Worked before? If so, with which NuGet version:

Detailed repro steps so we can see the same problem

...

Other suggested things

Verbose Logs

Please include verbose logs (NuGet.exe -verbosity detailed | dotnet.exe --verbosity diag | etc...)

Sample Project

Very helpful if you can zip a project and paste into this issue!

@nkolev92

This comment has been minimized.

Copy link
Member

@nkolev92 nkolev92 commented Dec 2, 2019

Just adding milestones and a bunch of labels :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.