Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Fixes in PM UI #9157

Closed
rrelyea opened this issue Feb 10, 2020 · 1 comment · Fixed by NuGet/NuGet.Client#3229, NuGet/NuGet.Client#3236 or NuGet/NuGet.Client#3237
Closed

Accessibility Fixes in PM UI #9157

rrelyea opened this issue Feb 10, 2020 · 1 comment · Fixed by NuGet/NuGet.Client#3229, NuGet/NuGet.Client#3236 or NuGet/NuGet.Client#3237

Comments

@rrelyea
Copy link
Contributor

@rrelyea rrelyea commented Feb 10, 2020

batch 3

  • 994456 - PackageDetail - Tags - A11y_NuGetClient-MinorUIChanges_TestPackageDeprecationOther_ScreenReader : Narrator does not announces "Blank" for the blank field.
  • 994459 - PackageDetail - A11y_NuGetClient-MinorUIChanges_TestPackage.Deprecation.Other_Installed_ScreenReader : Narrator is annoucing "Dependencies" for "No Dependencies" text.

batch 4

  • 994452 - PackageItem - A11y_NuGetClient-MinorUIChanges_Browse_ScreenReader : Screen reader focus is not going on the "version and Package Description" text.

batch 5

-1049215 - PackageDetail -nuget.org link- A11y_VS ASP.NET and Web Development_ Install Nuget Packages _ Screen Reader: Narrator is not reading the link text for “nuget.org” link
-994495 - PackageDetail - LicenseUI - A11y_NuGetClient-MinorUIChanges_TestPackage.Deprecation.CriticalBugs.AlternatePackage_Installed_ScreenReader : Narrator is not announcing the label association for the "MIT" link.

@rrelyea rrelyea added this to the Sprint 166 - 2020.02.10 milestone Feb 10, 2020
@rrelyea rrelyea self-assigned this Feb 10, 2020
@rrelyea rrelyea reopened this Feb 14, 2020
rrelyea added a commit to NuGet/NuGet.Client that referenced this issue Feb 15, 2020
…ree. (#3237)

* These hyperlinks both have 2 nodes in accessibility tree. Ideally, it can be done in one.

Fixes: NuGet/Home#9157 - batch 5
-[1049215](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1049215) - PackageDetail -nuget.org link- A11y_VS ASP.NET and Web Development_ Install Nuget Packages _ Screen Reader: Narrator is not reading the link text for “nuget.org” link
-[994495](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/994495) - PackageDetail - LicenseUI - A11y_NuGetClient-MinorUIChanges_TestPackage.Deprecation.CriticalBugs.AlternatePackage_Installed_ScreenReader : Narrator is not announcing the label association for the "MIT" link.

## Fix Details
Make each one of these cases have fewer nodes in accessibility tree.
rrelyea added a commit to NuGet/NuGet.Client that referenced this issue Feb 15, 2020
…ree. (#3237)

* These hyperlinks both have 2 nodes in accessibility tree. Ideally, it can be done in one.

Fixes: NuGet/Home#9157 - batch 5
-[1049215](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1049215) - PackageDetail -nuget.org link- A11y_VS ASP.NET and Web Development_ Install Nuget Packages _ Screen Reader: Narrator is not reading the link text for “nuget.org” link
-[994495](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/994495) - PackageDetail - LicenseUI - A11y_NuGetClient-MinorUIChanges_TestPackage.Deprecation.CriticalBugs.AlternatePackage_Installed_ScreenReader : Narrator is not announcing the label association for the "MIT" link.

## Fix Details
Make each one of these cases have fewer nodes in accessibility tree.
@rrelyea rrelyea reopened this Feb 18, 2020
@rrelyea

This comment has been minimized.

Copy link
Contributor Author

@rrelyea rrelyea commented Feb 18, 2020

Still waiting for 1 more signoff on: NuGet/NuGet.Client#3236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.