Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing format default on sources list #9337

Closed
jschwanz opened this issue Mar 24, 2020 · 2 comments
Closed

Missing format default on sources list #9337

jschwanz opened this issue Mar 24, 2020 · 2 comments

Comments

@jschwanz
Copy link

@jschwanz jschwanz commented Mar 24, 2020

Details about Problem

NuGet product used (NuGet.exe | VS UI | Package Manager Console | dotnet.exe): nuget.exe

NuGet version (x.x.x.xxx): 5.5.0

OS version (i.e. win10 v1607 (14393.321)): win10 v1909, windows-2019 (on Azure Pipelines)

Worked before? If so, with which NuGet version: 5.4.0

Detailed repro steps so we can see the same problem

  1. Run "nuget sources list"

With 5.4.0 (and earlier) this produces the detailed output of the sources list. With 5.5.0 it now produces this error:

invalid value for --format: None. Allowed values: 'detailed' or 'short'

The default format of 'detailed' is missing, and this is affecting downstream projects like PowerShellGet's Register-PSRepository cmdlet.

@jschwanz

This comment has been minimized.

Copy link
Author

@jschwanz jschwanz commented Mar 24, 2020

@rrelyea

This comment has been minimized.

Copy link
Contributor

@rrelyea rrelyea commented Mar 24, 2020

Thanks for the catch. Fix in PR now. Likely, we ship a 5.5.1 version of nuget.exe - but need approval first.

rrelyea added a commit to NuGet/NuGet.Client that referenced this issue Mar 25, 2020
Fixes: NuGet/Home#9337
Regression: Yes

Last working version: 5.4
How are we preventing it in future: added a test
Fix
If short or detailed isn't chosen, default to detailed. This is fixing a regression due to the `dotnet nuget list source` work in 5.5.

Testing/Validation
Tests Added: Yes
Validation:
- manual test.
- functional test.
rrelyea added a commit to NuGet/NuGet.Client that referenced this issue Mar 25, 2020
Fixes: NuGet/Home#9337
Regression: Yes

Last working version: 5.4
How are we preventing it in future: added a test
Fix
If short or detailed isn't chosen, default to detailed. This is fixing a regression due to the `dotnet nuget list source` work in 5.5.

Testing/Validation
Tests Added: Yes
Validation:
- manual test.
- functional test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.