Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically download and embed icon from iconUrl #9344

Open
chgill-MSFT opened this issue Mar 26, 2020 · 1 comment
Open

Automatically download and embed icon from iconUrl #9344

chgill-MSFT opened this issue Mar 26, 2020 · 1 comment

Comments

@chgill-MSFT
Copy link

@chgill-MSFT chgill-MSFT commented Mar 26, 2020

Problem: At some point nuget.org will stop accepting packages with iconUrls in favor of migrating package authors to embedded icons. This will require package authors to modify their current metadata practices.

Solution: Automatically download the image from the iconUrl and embed it into the nupkg at pack time. This will achieve the same benefits of embedded icons (because the icon will be embedded), while making the transition a seamless experience to the package author.

@chgill-MSFT chgill-MSFT transferred this issue from NuGet/NuGetGallery Mar 26, 2020
@rrelyea

This comment has been minimized.

Copy link
Contributor

@rrelyea rrelyea commented Mar 30, 2020

@dominoFire @karann-msft - you folks should understand this idea and see if it fits well
/c: @agr @aortiz-msft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.