Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManagedCodeConventions resolves MsBuild files in the root of build directory as NET00 tfm #965

Closed
pranavkm opened this issue Jul 17, 2015 · 6 comments
Assignees
Labels
Priority:2 Issues for the current backlog. Product:VS.Client Type:Bug
Milestone

Comments

@pranavkm
Copy link
Contributor

ManagedCodeConventions allows target and prop files to exist at the root of build directory. However, it assumes the tfm for these files is '.NetFramework Version = 0.0`. Consequently these files do not get installed in projects that are incompatible with the .net tfm (such as UAP)

@pranavkm
Copy link
Contributor Author

The right fix for this would be to resolve the tfm as Any framework. cc @davidfowl @anurse

@pranavkm pranavkm changed the title ManagedCodeConventions resolves the MsBuild files in the root of build directory as NET00 tfm ManagedCodeConventions resolves MsBuild files in the root of build directory as NET00 tfm Jul 17, 2015
@davidfowl
Copy link
Member

I wouldn't fix this generally. Only for build items

@pranavkm
Copy link
Contributor Author

Yup. Lib items should continue to be treated as net00

@emgarten emgarten added this to the 3.2.0-Beta milestone Jul 19, 2015
@emgarten emgarten added Product:VS.Client Priority:2 Issues for the current backlog. Type:Bug labels Jul 19, 2015
@analogrelay
Copy link

I would actually suggest moving to build\any\... for these, since the optional two-layer folder structure has been the reason NuGet has to update the server before packages can be uploaded for a new framework, even though the server doesn't really care. Isn't the idea of the Managed Code Conventions 2.0 to require a sub-folder, even if that sub-folder is just any?

@emgarten
Copy link
Member

@anurse I think this fix was mainly to get old packages working again, not for the new any convention. We should support build/any/id.targets.

Should we ignore TFM sub folders if files exist in the root, or should we ignore the root if tfm folders exist? It is messy to support both conventions, but I think we've already decided to do that here.

@emgarten
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:2 Issues for the current backlog. Product:VS.Client Type:Bug
Projects
None yet
Development

No branches or pull requests

4 participants