Minimal v2 protocol fixes #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| request.Headers.Accept.Add(a); | ||
| } | ||
|
|
||
| Func<HttpRequestMessage> requestFactory = () => request; |
There was a problem hiding this comment.
This should create a completely new request, see: #378
johnataylor
force-pushed
the
minimal-v2-protocol-fixes
branch
from
53d7643
to
104108a
Compare
johnataylor
force-pushed
the
minimal-v2-protocol-fixes
branch
from
104108a
to
67f2550
Compare
| @@ -126,6 +127,7 @@ private Task<IEnumerable<PackageInfo>> EnsurePackagesAsync(string id, Cancellati | |||
| // So we decide to leave current logic and observe. | |||
| using (var data = await _httpSource.GetAsync( | |||
| uri, | |||
| new[] { new MediaTypeWithQualityHeaderValue("application/atom+xml"), new MediaTypeWithQualityHeaderValue("application/xml") }, | |||
There was a problem hiding this comment.
nit: this looks like it should be a shared static so since it doesn't change but it used all over and recreated many times
|
🚀 |
johnataylor
force-pushed
the
minimal-v2-protocol-fixes
branch
from
67f2550
to
7f8b4c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yishaigalatzer
This pull request represents the minimal working changes for Klondike.
@csharpfritz
We are also expecting users to have to use Klondike with host/api/odata and not host/api because for 3.4 because we are not fixing the fact that we don't correctly processes odata base address. If the initial request is redirected our client won't work because the base address specified in the root OData ServiceDocument will not be picked up.