Add IVS API to GetNearest with fallback frameworks #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,7 +5,7 @@ | |||
| namespace NuGet.VisualStudio | |||
| { | |||
| [ComImport] | |||
| [Guid("4F3B122B-A53B-432C-8D85-0FAFB8BE4FF4")] | |||
| [Guid("BC58E90E-5400-46EC-B8CD-16C9FE6A8E43")] | |||
There was a problem hiding this comment.
I think this will break anyone who has these types embedded.
|
⌚ waiting on the guid change |
|
the rest looks great |
joelverhagen
force-pushed
the
jver-fallbackivs
branch
2 times, most recently
from
9aa45a6
to
ff30949
Compare
|
I spoke to @abpiskunov offline. He has verified this fix works for him. |
|
|
joelverhagen
force-pushed
the
jver-fallbackivs
branch
from
ff30949
to
4013395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses NuGet/Home#2633.
IVsFrameworkCompatibility2.GetNearestthat accepts fallback frameworks.@abpiskunov
@emgarten @yishaigalatzer @zhili1208 @rrelyea @alpaix @rohit21agrawal