fix for unable to create portable class library projects in VS2015 & Dev15 #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can you leave a comment about this change in behavior? Also, this still feels like a hack... do we have a work item to fix the installers and revert this change? Or do we intend on this being the functionality Forever? |
rohit21agrawal
force-pushed
the
dev-ragrawal-pclprojects
branch
3 times, most recently
from
fe931fd
to
2e84092
Compare
| // HACK !!! : This is a hack for PCL projects which send isPreUnzipped = true, but their package source | ||
| // (located at C:\Program Files (x86)\Microsoft SDKs\NuGetPackages) follows the V3 | ||
| // folder version format. | ||
| var isProjectJsonProject = await EnvDTEProjectUtility.HasBuildIntegratedConfig(project); |
There was a problem hiding this comment.
You only need this check if isPreUnzipped is true
|
Optimize the check, then |
rohit21agrawal
force-pushed
the
dev-ragrawal-pclprojects
branch
from
2e84092
to
3da2efa
Compare
|
@joelverhagen discussed this with @emgarten , it seems that there has been no change in behavior in the installer or the API calls . Since, Dev14 has already shipped , we will have to keep this hack forever in our code :( . |
|
thanks for the clarification @rohit21agrawal, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue : NuGet/Home#3094
PCL projects template creating code calls into VsPackageInstaller.InstallPackagesFromRegistryRepository and passes isUnzipped = true which causes NuGet to assume the v2 version folder format while looking for packages at C:\Program Files (x86)\Microsoft SDKs\NuGetPackages
However, the SDK installs these packages in the v3 version folder format causing NuGet to throw an invalid operation exception
This fix involves removing the assumption of using the v2 version folder format when isUnzipped=true is passed. Instead it determines the actual feed type using the logic build in the FeedTypeUtility class.
CC: @emgarten @joelverhagen @alpaix @yishaigalatzer @rrelyea