New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Issue: Organization forms are smaller then other forms #6725

Open
robertmuehsig opened this Issue Dec 5, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@robertmuehsig
Contributor

robertmuehsig commented Dec 5, 2018

I noticed that this form has much more spacing:

image

... then other forms, e.g.:

image

This leads to some "jumping" in the navigation:

gif

Also the org management page has some margins around the actual site, which is not present on the other pages:

image

Is this "by design" or a good candidate for "up for grabs"?

@scottbommarito

This comment has been minimized.

Member

scottbommarito commented Dec 5, 2018

I remember we initially had all of these forms only 10 columns instead of 12, but then we changed some of them to 12 but not all of them.

Culprit is 5749f9c
(notice the removal of ViewBag.MdPageColumns = Constants.ColumnsFormMd; in several files)

@joelverhagen - Do you remember why this was changed? Is it ok to go ahead with aligning these organization pages.

@anangaur - Do you like 10 or 12 columns for these pages better? I prefer 12, but it's up to you.

@anangaur

This comment has been minimized.

Member

anangaur commented Dec 6, 2018

The jump does look bad. We should be consistent. 12 looks better.

@robertmuehsig

This comment has been minimized.

Contributor

robertmuehsig commented Dec 6, 2018

If the NuGet Team is not to keen on fixing this in the next 12 hours I could send you a PR.

@scottbommarito

This comment has been minimized.

Member

scottbommarito commented Dec 6, 2018

@robertmuehsig - go ahead!

robertmuehsig added a commit to robertmuehsig/NuGetGallery that referenced this issue Dec 6, 2018

Fix NuGet#6725
Set column number from 10 to 12 and reenable this setting on uploadpackage/account/apikeys (constants were deleted in a previous commit)
@robertmuehsig

This comment has been minimized.

Contributor

robertmuehsig commented Dec 6, 2018

Ok - instead of removing this setting I just set it to 12 and re applied it to the missing pages.

image

The sm-12 md-??? calculation stuff seems to be used on all (? at least it seems very often) pages and with this setting you still could change it later globally.

Hope this helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment