Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce search load by rethinking the "is indexed" check #7716

Open
joelverhagen opened this issue Dec 2, 2019 · 1 comment
Assignees
Labels

Comments

@joelverhagen
Copy link
Member

@joelverhagen joelverhagen commented Dec 2, 2019

Today, the "is indexed" check has the following properties:

  • Cached (for 30 seconds)
  • Executed for all available package versions
    • no matter the age (even if it is months or years old)
    • even if it is unlisted (which is probably fine)
  • Executed for unauthenticated requests

a

We can re-evaluate pretty much everything here. For example:

  1. Only show it to the owner of the package
    • This is a bit of a take-back but since indexing times are a minority of the package's lifetime it's probably not interesting for consumers
  2. Only check for the first day of the package's "life" (probably since last edited)
  3. Increase cache duration

Related to NuGet/Engineering#2773.

@joelverhagen joelverhagen self-assigned this Dec 2, 2019
joelverhagen added a commit that referenced this issue Dec 4, 2019
Address #7716
joelverhagen added a commit that referenced this issue Dec 4, 2019
Address #7716
joelverhagen added a commit that referenced this issue Dec 5, 2019
Address #7716
joelverhagen added a commit that referenced this issue Dec 5, 2019
Address #7716
@joelverhagen joelverhagen added this to the S162 - 2019.11.18 milestone Dec 5, 2019
@joelverhagen

This comment has been minimized.

Copy link
Member Author

@joelverhagen joelverhagen commented Dec 5, 2019

The approach we took is to only do the "is indexed" check up to 1 day after the package was created/last edited. We did not want to degrade the experience of unauthenticated users who currently see this "still indexing" warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.