Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PackageType]Update Gallery to reject invalid package types #7766

Closed
ryuyu opened this issue Dec 10, 2019 · 0 comments
Closed

[PackageType]Update Gallery to reject invalid package types #7766

ryuyu opened this issue Dec 10, 2019 · 0 comments

Comments

@ryuyu
Copy link
Contributor

@ryuyu ryuyu commented Dec 10, 2019

Currently, gallery appears to do very little validation of packageTypes node on package upload.
This allows packageTypes that are invalid (according to spec) to be pushed to gallery.

These package types are effectively meaningless, and should be rejected at push time/nuspec validation time.

@ryuyu ryuyu self-assigned this Dec 10, 2019
joelverhagen added a commit that referenced this issue Dec 18, 2019
Clear previous package types during reflow: #7780
Reject invalid package type names: #7766
joelverhagen added a commit that referenced this issue Dec 18, 2019
Clear previous package types during reflow: #7780
Reject invalid package type names: #7766
@joelverhagen joelverhagen assigned joelverhagen and unassigned ryuyu Dec 19, 2019
@joelverhagen joelverhagen added this to the S163 - 2019.12.09 milestone Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.