Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new version of a package shows previous icon #7792

Closed
gsscoder opened this issue Dec 30, 2019 · 2 comments
Closed

A new version of a package shows previous icon #7792

gsscoder opened this issue Dec 30, 2019 · 2 comments
Assignees

Comments

@gsscoder
Copy link

@gsscoder gsscoder commented Dec 30, 2019

I've recently pushed a release with a new icon, but I still se the previous one on NuGet.org.

package link:
https://www.nuget.org/packages/CSharpx/1.2.3-rc2

github of the project:
https://github.com/gsscoder/csharpx

I had to use deprecated PackageIconUrl because, it's seem impossible to point a file with PackageIcon.

Thanks in advance.

@skofman1 skofman1 added this to the S164 - 2019.12.30 milestone Jan 10, 2020
@agr

This comment has been minimized.

Copy link
Contributor

@agr agr commented Jan 11, 2020

Apologies for the late response. I see that you figured out how to ship your icon with the package. I just had the icon updated on the older versions that had package URL specified.

Do you think our icon packaging documentation is lacking some details that prevented you to make it work in the first place? Any improvement suggestions?

@gsscoder

This comment has been minimized.

Copy link
Author

@gsscoder gsscoder commented Jan 11, 2020

@agr, no need to apologize! Instead thanks for excellent web app.

It was my fault... I didn't create a NuGet package for years and forgot how to pin the icon locally. Using URL is not properly updated, but this is not a problem since PackageIconUrl is deprecated.

I can't say about documentation, I solved using Visual Studio UI and than inspecting how it modified csproj.
Anyway is better to point out the need of PackageIcon and ItemGroup tags.

Thank you

@gsscoder gsscoder closed this Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.