Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error message when PDB does not match DLL #7844

Closed
joelverhagen opened this issue Feb 12, 2020 · 1 comment
Closed

Incorrect error message when PDB does not match DLL #7844

joelverhagen opened this issue Feb 12, 2020 · 1 comment

Comments

@joelverhagen
Copy link
Member

@joelverhagen joelverhagen commented Feb 12, 2020

Describe the bug

A user wants to update their .snupkg associated with an already pushed package:
https://www.nuget.org/packages/tusdotnet/2.2.2

There is an existing .snupkg that was accepted but subsequent attempts fail with this error:

The uploaded symbols package contains one or more pdbs that are not portable.

However upon closer investigation, the failure is not because the PDBs are portable but because the PEReader saw that the PDB and DLL do not match.

I think the error is here:
https://github.com/NuGet/NuGet.Jobs/blob/dbd927c309005b63b82c1017ff6bfcfec96434cf/src/Validation.Symbols/SymbolsValidatorService.cs#L251

This should use the error message ValidationIssue.SymbolErrorCode_MatchingAssemblyNotFound.

To Reproduce

Upload a snupkg with a portable PDB that matches in name but does not match according to PEReader.TryOpenAssociatedPortablePdb.

Expected behavior

The validation should fail with a more helpful error message.

Screenshots

image

Additional context

Add any other context about the problem here.

joelverhagen added a commit to NuGet/NuGet.Jobs that referenced this issue Feb 13, 2020
joelverhagen added a commit to NuGet/NuGet.Jobs that referenced this issue Feb 13, 2020
@joelverhagen joelverhagen self-assigned this Feb 13, 2020
@joelverhagen joelverhagen added this to the Sprint 166 - 2020.02.10 milestone Feb 14, 2020
@joelverhagen

This comment has been minimized.

Copy link
Member Author

@joelverhagen joelverhagen commented Feb 19, 2020

There new message looks like this:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.