New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1792 by giving senders a copy of emails sent by the gallery. #1794

Merged
merged 8 commits into from Jan 8, 2014

Conversation

Projects
None yet
3 participants
@anurse
Member

anurse commented Dec 11, 2013

Fixes #1792

Originally contributed by @zippy1981

Test Notes:

  • When "Contact Owners" is used, the sender receives a copy of the email that DOES NOT DISCLOSE THE OWNER NAMES AND ADDRESSES
  • Report Abuse AND Contact Support messages CC their senders
  • Report Abuse AND Contact Support messages DO NOT include a listing of owners and their email addresses
@anurse

This comment has been minimized.

Show comment
Hide comment
@anurse

anurse Dec 11, 2013

Member

Ready for Code Review!

Member

anurse commented Dec 11, 2013

Ready for Code Review!

@@ -250,7 +250,7 @@ private ActionResult RedirectFromRegister(string returnUrl)
return RedirectToAction(MVC.Users.Thanks());
}
private async Task<AuthenticatedUser> AssociateCredential(AuthenticatedUser user, string returnUrl)
private async Task<AuthenticatedUser> AssociateCredential(AuthenticatedUser user)

This comment has been minimized.

@anurse

anurse Dec 11, 2013

Member

This was the cause of a strange, unrelated, build error only occurring on the CI machine. I'll investigate further, but it seems to be a benign addition to the changes, since the parameter was unused.

@anurse

anurse Dec 11, 2013

Member

This was the cause of a strange, unrelated, build error only occurring on the CI machine. I'll investigate further, but it seems to be a benign addition to the changes, since the parameter was unused.

@@ -7,6 +7,7 @@
using AnglicanGeek.MarkdownMailer;
using Elmah;
using NuGetGallery.Authentication;
using Glimpse.AspNet.AlternateType;

This comment has been minimized.

@jeffhandley

jeffhandley Dec 18, 2013

Member

Sort those usings

@jeffhandley

jeffhandley Dec 18, 2013

Member

Sort those usings

@jeffhandley

This comment has been minimized.

Show comment
Hide comment
@jeffhandley
Member

jeffhandley commented Dec 18, 2013

:shipit:

anurse added a commit that referenced this pull request Jan 8, 2014

Merge pull request #1794 from NuGet/zippy1981/1792-ccsenderonemails
Fix #1792 by giving senders a copy of emails sent by the gallery.

@anurse anurse merged commit 305acf8 into master Jan 8, 2014

1 check passed

default TeamCity Build Gallery :: Main :: Pull Requests finished: Tests passed: 874
Details

@anurse anurse deleted the zippy1981/1792-ccsenderonemails branch Apr 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment