Fix #1792 by giving senders a copy of emails sent by the gallery. #1794

Merged
merged 8 commits into from Jan 8, 2014

Projects

None yet

3 participants

@anurse
Member
anurse commented Dec 11, 2013

Fixes #1792

Originally contributed by @zippy1981

Test Notes:

  • When "Contact Owners" is used, the sender receives a copy of the email that DOES NOT DISCLOSE THE OWNER NAMES AND ADDRESSES
  • Report Abuse AND Contact Support messages CC their senders
  • Report Abuse AND Contact Support messages DO NOT include a listing of owners and their email addresses
@anurse
Member
anurse commented Dec 11, 2013

Ready for Code Review!

@anurse anurse commented on the diff Dec 11, 2013
src/NuGetGallery/Controllers/AuthenticationController.cs
@@ -250,7 +250,7 @@ private ActionResult RedirectFromRegister(string returnUrl)
return RedirectToAction(MVC.Users.Thanks());
}
- private async Task<AuthenticatedUser> AssociateCredential(AuthenticatedUser user, string returnUrl)
+ private async Task<AuthenticatedUser> AssociateCredential(AuthenticatedUser user)
@anurse
anurse Dec 11, 2013 Member

This was the cause of a strange, unrelated, build error only occurring on the CI machine. I'll investigate further, but it seems to be a benign addition to the changes, since the parameter was unused.

@jeffhandley jeffhandley commented on the diff Dec 18, 2013
src/NuGetGallery/Services/MessageService.cs
@@ -7,6 +7,7 @@
using AnglicanGeek.MarkdownMailer;
using Elmah;
using NuGetGallery.Authentication;
+using Glimpse.AspNet.AlternateType;
@jeffhandley
jeffhandley Dec 18, 2013 Member

Sort those usings

@jeffhandley
Member

:shipit:

@anurse anurse merged commit 305acf8 into master Jan 8, 2014

1 check passed

default TeamCity Build Gallery :: Main :: Pull Requests finished: Tests passed: 874
Details
@anurse anurse deleted the zippy1981/1792-ccsenderonemails branch Apr 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment