Fixes to Manageownerspage #1798

Merged
merged 1 commit into from Jan 15, 2014

Conversation

Projects
None yet
4 participants
@bhuvak
Contributor

bhuvak commented Dec 12, 2013

Fixes #1760 and #1741

Validated the relevant scenarios manually.
Request folks to review the error messages as well.

+ }
+ if (!user.Confirmed)
+ {
+ return new { success = false, message = string.Format("Sorry, {0} hasn't verified his email account yet and we cannot proceed with the request.",username) };

This comment has been minimized.

Show comment Hide comment
@jeffhandley

jeffhandley Dec 18, 2013

Member

Use "...hasn't verified their email address..." I know "their" isn't singular, but as a grammar purist myself, I say oh well.

@jeffhandley

jeffhandley Dec 18, 2013

Member

Use "...hasn't verified their email address..." I know "their" isn't singular, but as a grammar purist myself, I say oh well.

This comment has been minimized.

Show comment Hide comment
@jeffhandley

jeffhandley Dec 18, 2013

Member

Nit: Looks like a missing space before the username parameter. Formatting the code block would fix it.

@jeffhandley

jeffhandley Dec 18, 2013

Member

Nit: Looks like a missing space before the username parameter. Formatting the code block would fix it.

This comment has been minimized.

Show comment Hide comment
@anurse

anurse Dec 18, 2013

Member

"they", "their", etc. are singular in exactly this case: http://dictionary.reference.com/browse/they - "(used with an indefinite singular antecedent in place of the definite masculine he or the definite feminine she)"

So even purists can be happy :)

@anurse

anurse Dec 18, 2013

Member

"they", "their", etc. are singular in exactly this case: http://dictionary.reference.com/browse/they - "(used with an indefinite singular antecedent in place of the definite masculine he or the definite feminine she)"

So even purists can be happy :)

This comment has been minimized.

Show comment Hide comment
@jeffhandley

jeffhandley Dec 18, 2013

Member

You just made my day, good sir!

@jeffhandley

jeffhandley Dec 18, 2013

Member

You just made my day, good sir!

claycompton added a commit that referenced this pull request Jan 15, 2014

@claycompton claycompton merged commit 0f68f30 into master Jan 15, 2014

1 check was pending

default TeamCity Build Gallery :: Main :: Pull Requests started
Details

claycompton added a commit that referenced this pull request Jan 15, 2014

@anurse

This comment has been minimized.

Show comment Hide comment
@anurse

anurse Jan 29, 2014

Member

The grammar comment was never resolved before this was merged in. I'm going to fix that up in a separate change.

Member

anurse commented Jan 29, 2014

The grammar comment was never resolved before this was merged in. I'm going to fix that up in a separate change.

anurse added a commit that referenced this pull request Jan 29, 2014

anurse added a commit that referenced this pull request Jan 30, 2014

@anurse anurse deleted the bhuvak-manageowner-1760 branch Apr 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment