Fix #1867 to enable <developmentDependency> works #1870

Merged
merged 5 commits into from Feb 4, 2014

Projects

None yet

4 participants

@anurse
Member
anurse commented Feb 1, 2014
  1. We no longer validate the schema, since that blocks new elements from working
  2. Updated NuGet.Core to 2.8

(We can easily do 2 without 1 if we decide we'd rather work that way. Open for discussion)

Fixes #1867

@bhuvak
bhuvak commented Feb 3, 2014

Looks good.

@jeffhandley
Member

I'd like to keep the schema validation for now, but we do need to update to NuGet.Core 2.8.

@anurse
Member
anurse commented Feb 3, 2014

Ok, I'll remove the schema validation change.

@anurse
Member
anurse commented Feb 3, 2014

There are test failures that I'm currently fixing, then this is ready to merge.

@anurse
Member
anurse commented Feb 3, 2014

I'm going to throw the connection timeout change in here as well. Stand by

@claycompton
Member

Any update on this? Should I expect this update to the PR tonight?

Thanks,
Clay

From: Andrew Nurse [mailto:notifications@github.com]
Sent: Monday, February 3, 2014 2:56 PM
To: NuGet/NuGetGallery
Subject: Re: [NuGetGallery] Fix #1867 to enable works (#1870)

I'm going to throw the connection timeout change in here as well. Stand by


Reply to this email directly or view it on GitHubhttps://github.com/NuGet/NuGetGallery/pull/1870#issuecomment-34010930.

@anurse
Member
anurse commented Feb 4, 2014

It's ready to go, thanks for pinging. Merging to master now.

@anurse anurse merged commit f61b64e into master Feb 4, 2014

1 check passed

Details default TeamCity Build Services :: NuGet Gallery :: Pull Requests finished: Tests passed: 877
@anurse
Member
anurse commented Feb 4, 2014

(FYI, we can just merge master over to QA to get everything, no need to cherry-pick. This is the only thing in master that isn't in QA as far as I can tell)

@claycompton
Member

Thanks for the tip.

-Clay

From: Andrew Nurse [mailto:notifications@github.com]
Sent: Monday, February 3, 2014 5:00 PM
To: NuGet/NuGetGallery
Cc: Clay Compton
Subject: Re: [NuGetGallery] Fix #1867 to enable works (#1870)

(FYI, we can just merge master over to QA to get everything, no need to cherry-pick. This is the only thing in master that isn't in QA as far as I can tell)


Reply to this email directly or view it on GitHubhttps://github.com/NuGet/NuGetGallery/pull/1870#issuecomment-34020063.

@anurse anurse deleted the anurse/1867-stopvalidatingschema branch Apr 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment